third_party/WebKit/Source/core/editing/serializers/MarkupAccumulator.h - Issue 2531163004: Remove attributes that contain javascript from MHTML

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/serializers/MarkupAccumulator.h

Issue 2531163004: Remove attributes that contain javascript from MHTML (Closed)

Patch Set: Address final feedback Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/dom/Element.cpp ('k') | third_party/WebKit/Source/core/editing/serializers/MarkupAccumulator.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/serializers/MarkupAccumulator.h

diff --git a/third_party/WebKit/Source/core/editing/serializers/MarkupAccumulator.h b/third_party/WebKit/Source/core/editing/serializers/MarkupAccumulator.h

index 1a6247e37b48a6072900dbb0d06ac477e0fc72e4..b221481e9642d7bacb44a9fa15ecd63be0de7132 100644

--- a/third_party/WebKit/Source/core/editing/serializers/MarkupAccumulator.h

+++ b/third_party/WebKit/Source/core/editing/serializers/MarkupAccumulator.h

@@ -64,7 +64,7 @@ class MarkupAccumulator {

Namespaces*);

virtual void appendText(StringBuilder&, Text&);

- virtual bool shouldIgnoreAttribute(const Attribute&);

+ virtual bool shouldIgnoreAttribute(const Element&, const Attribute&);

virtual void appendElement(StringBuilder&, Element&, Namespaces*);

void appendOpenTag(StringBuilder&, const Element&, Namespaces*);

void appendCloseTag(StringBuilder&, const Element&);