Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3364)

Unified Diff: chrome/browser/chrome_content_browser_client.cc

Issue 2531133002: Convert SetIsIncognitoProcess to use mojo. (Closed)
Patch Set: Convert SetIsIncognitoProcess to use mojo. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/common/BUILD.gn » ('j') | chrome/common/renderer.mojom » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chrome_content_browser_client.cc
diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/chrome_content_browser_client.cc
index 1c7ce3b7eb720ea5a87af2bd1158e39a2da07c23..822e38f519f59c69076d08dab20ff61ed24112d7 100644
--- a/chrome/browser/chrome_content_browser_client.cc
+++ b/chrome/browser/chrome_content_browser_client.cc
@@ -108,6 +108,7 @@
#include "chrome/common/pepper_permission_util.h"
#include "chrome/common/pref_names.h"
#include "chrome/common/render_messages.h"
+#include "chrome/common/renderer.mojom.h"
#include "chrome/common/secure_origin_whitelist.h"
#include "chrome/common/stack_sampling_configuration.h"
#include "chrome/common/url_constants.h"
@@ -1077,8 +1078,9 @@ void ChromeContentBrowserClient::RenderProcessWillLaunch(
host->AddFilter(new cdm::CdmMessageFilterAndroid());
#endif
- host->Send(new ChromeViewMsg_SetIsIncognitoProcess(
- profile->IsOffTheRecord()));
+ chrome::mojom::InitialConfigurationParamsPtr ic_params =
+ chrome::mojom::InitialConfigurationParams::New();
+ ic_params->is_incognito_process = profile->IsOffTheRecord();
for (size_t i = 0; i < extra_parts_.size(); ++i)
extra_parts_[i]->RenderProcessWillLaunch(host);
@@ -1094,7 +1096,14 @@ void ChromeContentBrowserClient::RenderProcessWillLaunch(
GetRendererContentSettingRules(
HostContentSettingsMapFactory::GetForProfile(profile), &rules);
}
+
+ // TODO(nigeltao): eliminate this legacy IPC. Instead, define new fields for
+ // chrome::mojom::InitialConfigurationParams and populate ic_params here.
host->Send(new ChromeViewMsg_SetContentSettingRules(rules));
+
+ chrome::mojom::RendererAssociatedPtr renderer_interface;
+ host->GetChannel()->GetRemoteAssociatedInterface(&renderer_interface);
+ renderer_interface->InitialConfiguration(std::move(ic_params));
}
GURL ChromeContentBrowserClient::GetEffectiveURL(
« no previous file with comments | « no previous file | chrome/common/BUILD.gn » ('j') | chrome/common/renderer.mojom » ('J')

Powered by Google App Engine
This is Rietveld 408576698