Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(724)

Unified Diff: chrome/browser/chrome_content_browser_client.cc

Issue 2531133002: Convert SetIsIncognitoProcess to use mojo. (Closed)
Patch Set: Convert SetIsIncognitoProcess to use mojo. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/common/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chrome_content_browser_client.cc
diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/chrome_content_browser_client.cc
index 793cedd756347b76ec64b3553f8207a0b2132c27..bfb73d1f35ab718d9f2fbf1f7285c0b5bd2f05ca 100644
--- a/chrome/browser/chrome_content_browser_client.cc
+++ b/chrome/browser/chrome_content_browser_client.cc
@@ -109,6 +109,7 @@
#include "chrome/common/pepper_permission_util.h"
#include "chrome/common/pref_names.h"
#include "chrome/common/render_messages.h"
+#include "chrome/common/renderer_configuration.mojom.h"
#include "chrome/common/secure_origin_whitelist.h"
#include "chrome/common/stack_sampling_configuration.h"
#include "chrome/common/url_constants.h"
@@ -1082,8 +1083,11 @@ void ChromeContentBrowserClient::RenderProcessWillLaunch(
host->AddFilter(new cdm::CdmMessageFilterAndroid());
#endif
- host->Send(new ChromeViewMsg_SetIsIncognitoProcess(
- profile->IsOffTheRecord()));
+ bool is_incognito_process = profile->IsOffTheRecord();
+
+ chrome::mojom::RendererConfigurationAssociatedPtr rc_interface;
+ host->GetChannel()->GetRemoteAssociatedInterface(&rc_interface);
+ rc_interface->SetInitialConfiguration(is_incognito_process);
for (size_t i = 0; i < extra_parts_.size(); ++i)
extra_parts_[i]->RenderProcessWillLaunch(host);
@@ -1091,7 +1095,7 @@ void ChromeContentBrowserClient::RenderProcessWillLaunch(
RendererContentSettingRules rules;
if (host->IsForGuestsOnly()) {
#if BUILDFLAG(ENABLE_EXTENSIONS)
- GetGuestViewDefaultContentSettingRules(profile->IsOffTheRecord(), &rules);
+ GetGuestViewDefaultContentSettingRules(is_incognito_process, &rules);
#else
NOTREACHED();
#endif
@@ -1099,6 +1103,8 @@ void ChromeContentBrowserClient::RenderProcessWillLaunch(
GetRendererContentSettingRules(
HostContentSettingsMapFactory::GetForProfile(profile), &rules);
}
+ // TODO(nigeltao): eliminate this legacy IPC. Instead, add an extra arg to
+ // the rc_interface->SetInitialConfiguration call.
host->Send(new ChromeViewMsg_SetContentSettingRules(rules));
}
« no previous file with comments | « no previous file | chrome/common/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698