Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Unified Diff: components/browser_watcher/BUILD.gn

Issue 2531123002: Record MetricsService's execution phase to the stability file (Closed)
Patch Set: fix issue with incorrect kStabilityExecutionPhase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/browser_watcher/BUILD.gn
diff --git a/components/browser_watcher/BUILD.gn b/components/browser_watcher/BUILD.gn
index 5d64eed5cce6b19a3b2c23e8fe8d0f561f29e42f..95b431e4cff5cdc18a6409d80978cfde51ba32ff 100644
--- a/components/browser_watcher/BUILD.gn
+++ b/components/browser_watcher/BUILD.gn
@@ -4,79 +4,81 @@
import("//third_party/protobuf/proto_library.gni")
-proto_library("stability_report_proto") {
- sources = [
- "stability_report.proto",
- ]
-}
+if (is_win) {
+ proto_library("stability_report_proto") {
+ sources = [
+ "stability_report.proto",
+ ]
+ }
-static_library("browser_watcher") {
- # This is a separate lib to minimize the dependencies for its
- # hosting binary "chrome_watcher.dll".
- sources = [
- "endsession_watcher_window_win.cc",
- "endsession_watcher_window_win.h",
- "exit_code_watcher_win.cc",
- "exit_code_watcher_win.h",
- "window_hang_monitor_win.cc",
- "window_hang_monitor_win.h",
- ]
- deps = [
- "//base",
- ]
-}
+ static_library("browser_watcher") {
+ # This is a separate lib to minimize the dependencies for its
+ # hosting binary "chrome_watcher.dll".
+ sources = [
+ "endsession_watcher_window_win.cc",
+ "endsession_watcher_window_win.h",
+ "exit_code_watcher_win.cc",
+ "exit_code_watcher_win.h",
+ "window_hang_monitor_win.cc",
+ "window_hang_monitor_win.h",
+ ]
+ deps = [
+ "//base",
+ ]
+ }
-static_library("browser_watcher_client") {
- sources = [
- "watcher_client_win.cc",
- "watcher_client_win.h",
- "watcher_metrics_provider_win.cc",
- "watcher_metrics_provider_win.h",
- ]
- deps = [
- ":postmortem_report_collector",
- ":stability",
- "//base",
- "//components/metrics",
- "//third_party/crashpad/crashpad/client",
- ]
-}
+ static_library("browser_watcher_client") {
+ sources = [
+ "watcher_client_win.cc",
+ "watcher_client_win.h",
+ "watcher_metrics_provider_win.cc",
+ "watcher_metrics_provider_win.h",
+ ]
+ deps = [
+ ":postmortem_report_collector",
+ ":stability",
+ "//base",
+ "//components/metrics",
+ "//third_party/crashpad/crashpad/client",
+ ]
+ }
-static_library("postmortem_minidump_writer") {
- # TODO(manzagop): remove this lib once Crashpad writes the minidumps.
- sources = [
- "postmortem_minidump_writer.h",
- "postmortem_minidump_writer_win.cc",
- ]
- deps = [
- ":stability_report_proto",
- "//base",
- "//third_party/crashpad/crashpad/client",
- "//third_party/crashpad/crashpad/minidump",
- "//third_party/crashpad/crashpad/util",
- ]
-}
+ static_library("postmortem_minidump_writer") {
+ # TODO(manzagop): remove this lib once Crashpad writes the minidumps.
+ sources = [
+ "postmortem_minidump_writer.h",
+ "postmortem_minidump_writer_win.cc",
+ ]
+ deps = [
+ ":stability_report_proto",
+ "//base",
+ "//third_party/crashpad/crashpad/client",
+ "//third_party/crashpad/crashpad/minidump",
+ "//third_party/crashpad/crashpad/util",
+ ]
+ }
-static_library("postmortem_report_collector") {
- sources = [
- "postmortem_report_collector.cc",
- "postmortem_report_collector.h",
- ]
- deps = [
- ":postmortem_minidump_writer",
- ":stability_report_proto",
- "//base",
- "//third_party/crashpad/crashpad/client",
- "//third_party/crashpad/crashpad/util",
- ]
+ static_library("postmortem_report_collector") {
+ sources = [
+ "postmortem_report_collector.cc",
+ "postmortem_report_collector.h",
+ ]
+ deps = [
+ ":postmortem_minidump_writer",
+ ":stability_report_proto",
+ "//base",
+ "//third_party/crashpad/crashpad/client",
+ "//third_party/crashpad/crashpad/util",
+ ]
+ }
}
static_library("stability") {
sources = [
"features.cc",
"features.h",
- "stability_debugging_win.cc",
- "stability_debugging_win.h",
+ "stability_debugging.cc",
+ "stability_debugging.h",
]
deps = [
"//base",
@@ -90,44 +92,46 @@ static_library("stability_data") {
]
}
-source_set("unit_tests") {
- testonly = true
- sources = [
- "endsession_watcher_window_win_unittest.cc",
- "exit_code_watcher_win_unittest.cc",
- "postmortem_minidump_writer_win_unittest.cc",
- "postmortem_report_collector_unittest.cc",
- "watcher_client_win_unittest.cc",
- "watcher_metrics_provider_win_unittest.cc",
- "window_hang_monitor_win_unittest.cc",
- ]
- configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
- deps = [
- ":browser_watcher",
- ":browser_watcher_client",
- ":postmortem_minidump_writer",
- ":postmortem_report_collector",
- ":stability_report_proto",
- "//base",
- "//base/test:test_support",
- "//testing/gmock",
- "//testing/gtest",
- "//third_party/crashpad/crashpad/client",
+if (is_win) {
+ source_set("unit_tests") {
+ testonly = true
+ sources = [
+ "endsession_watcher_window_win_unittest.cc",
+ "exit_code_watcher_win_unittest.cc",
+ "postmortem_minidump_writer_win_unittest.cc",
+ "postmortem_report_collector_unittest.cc",
+ "watcher_client_win_unittest.cc",
+ "watcher_metrics_provider_win_unittest.cc",
+ "window_hang_monitor_win_unittest.cc",
+ ]
+ configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
+ deps = [
+ ":browser_watcher",
+ ":browser_watcher_client",
+ ":postmortem_minidump_writer",
+ ":postmortem_report_collector",
+ ":stability_report_proto",
+ "//base",
+ "//base/test:test_support",
+ "//testing/gmock",
+ "//testing/gtest",
+ "//third_party/crashpad/crashpad/client",
- # TODO(manzagop): remove this lib once Crashpad writes the minidumps.
- "//third_party/crashpad/crashpad/compat",
- "//third_party/crashpad/crashpad/minidump",
- "//third_party/crashpad/crashpad/snapshot",
- "//third_party/crashpad/crashpad/util",
- ]
-}
+ # TODO(manzagop): remove this lib once Crashpad writes the minidumps.
+ "//third_party/crashpad/crashpad/compat",
+ "//third_party/crashpad/crashpad/minidump",
+ "//third_party/crashpad/crashpad/snapshot",
+ "//third_party/crashpad/crashpad/util",
+ ]
+ }
-executable("dump_postmortem") {
- sources = [
- "dump_postmortem_minidump_main_win.cc",
- ]
- deps = [
- ":stability_report_proto",
- "//base",
- ]
+ executable("dump_postmortem") {
+ sources = [
+ "dump_postmortem_minidump_main_win.cc",
+ ]
+ deps = [
+ ":stability_report_proto",
+ "//base",
+ ]
+ }
}
« no previous file with comments | « chrome/browser/metrics/chrome_metrics_service_client.cc ('k') | components/browser_watcher/stability_data_names.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698