Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(694)

Unified Diff: components/browser_watcher/stability_debugging_win.cc

Issue 2531123002: Record MetricsService's execution phase to the stability file (Closed)
Patch Set: fix issue with incorrect kStabilityExecutionPhase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/browser_watcher/stability_debugging_win.cc
diff --git a/components/browser_watcher/stability_debugging_win.cc b/components/browser_watcher/stability_debugging_win.cc
deleted file mode 100644
index 3eb4e47b2affb3eac0e7f5a1995dcb4781810dbe..0000000000000000000000000000000000000000
--- a/components/browser_watcher/stability_debugging_win.cc
+++ /dev/null
@@ -1,88 +0,0 @@
-// Copyright 2016 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "components/browser_watcher/stability_debugging_win.h"
-
-#include <string>
-
-#include "base/feature_list.h"
-#include "base/files/file.h"
-#include "base/metrics/persistent_memory_allocator.h"
-#include "base/path_service.h"
-#include "base/process/process.h"
-#include "base/strings/stringprintf.h"
-#include "base/time/time.h"
-#include "components/browser_watcher/features.h"
-
-namespace browser_watcher {
-
-namespace {
-
-bool GetCreationTime(const base::Process& process, base::Time* time) {
- DCHECK(time);
-
- FILETIME creation_time = {};
- FILETIME ignore1 = {};
- FILETIME ignore2 = {};
- FILETIME ignore3 = {};
- if (!::GetProcessTimes(process.Handle(), &creation_time, &ignore1, &ignore2,
- &ignore3)) {
- return false;
- }
- *time = base::Time::FromFileTime(creation_time);
- return true;
-}
-
-} // namespace
-
-base::FilePath GetStabilityDir(const base::FilePath& user_data_dir) {
- return user_data_dir.AppendASCII("Stability");
-}
-
-bool GetStabilityFileForProcess(const base::Process& process,
- const base::FilePath& user_data_dir,
- base::FilePath* file_path) {
- DCHECK(file_path);
- base::FilePath stability_dir = GetStabilityDir(user_data_dir);
-
- // Build the name using the pid and creation time. On windows, this is unique
- // even after the process exits.
- base::Time creation_time;
- if (!GetCreationTime(process, &creation_time))
- return false;
-
- std::string file_name =
- base::StringPrintf("%u-%llu", process.Pid(), creation_time.ToJavaTime());
- *file_path = stability_dir.AppendASCII(file_name).AddExtension(
- base::PersistentMemoryAllocator::kFileExtension);
- return true;
-}
-
-base::FilePath::StringType GetStabilityFilePattern() {
- return base::FilePath::StringType(FILE_PATH_LITERAL("*-*")) +
- base::PersistentMemoryAllocator::kFileExtension;
-}
-
-void MarkStabilityFileForDeletion(const base::FilePath& user_data_dir) {
- if (!base::FeatureList::IsEnabled(
- browser_watcher::kStabilityDebuggingFeature)) {
- return;
- }
-
- base::FilePath stability_file;
- if (!GetStabilityFileForProcess(base::Process::Current(), user_data_dir,
- &stability_file)) {
- // TODO(manzagop): add a metric for this.
- return;
- }
-
- // Open (with delete) and then immediately close the file by going out of
- // scope. This should cause the stability debugging file to be deleted prior
- // to the next execution.
- base::File file(stability_file, base::File::FLAG_OPEN |
- base::File::FLAG_READ |
- base::File::FLAG_DELETE_ON_CLOSE);
-}
-
-} // namespace browser_watcher
« no previous file with comments | « components/browser_watcher/stability_debugging_win.h ('k') | components/browser_watcher/watcher_metrics_provider_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698