Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 2531093002: [heap] Replace NewSpacePageRange with PageRange (Closed)

Created:
4 years ago by Michael Lippautz
Modified:
4 years ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Replace NewSpacePageRange with PageRange Trivial parts of the reverted CL: https://codereview.chromium.org/2516303006/ BUG= Committed: https://crrev.com/0e74286133fe5d2bfc05f3c2b901b3d849db9d12 Cr-Commit-Position: refs/heads/master@{#41288}

Patch Set 1 #

Patch Set 2 : Fix compilation #

Patch Set 3 : Fix missed replace #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -26 lines) Patch
M src/heap/array-buffer-tracker.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/heap/heap.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/heap/mark-compact.cc View 1 2 6 chunks +6 lines, -6 lines 0 comments Download
M src/heap/spaces.h View 2 chunks +2 lines, -11 lines 0 comments Download
M src/heap/spaces.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/spaces-inl.h View 1 1 chunk +8 lines, -4 lines 0 comments Download

Messages

Total messages: 20 (14 generated)
Hannes Payer (out of office)
lgtm
4 years ago (2016-11-25 15:07:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2531093002/20001
4 years ago (2016-11-25 15:10:47 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/builds/12825) v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED, ...
4 years ago (2016-11-25 15:13:17 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2531093002/40001
4 years ago (2016-11-25 15:15:18 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-11-25 15:44:07 UTC) #18
commit-bot: I haz the power
4 years ago (2016-11-25 15:44:36 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0e74286133fe5d2bfc05f3c2b901b3d849db9d12
Cr-Commit-Position: refs/heads/master@{#41288}

Powered by Google App Engine
This is Rietveld 408576698