Implement FakeAuthPolicyClient::RefreshDevicePolicy()

chromeos/dbus/fake_auth_policy_client.h

 // Copyright (c) 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROMEOS_DBUS_FAKE_AUTH_POLICY_CLIENT_H_
 #define CHROMEOS_DBUS_FAKE_AUTH_POLICY_CLIENT_H_
 
 #include <string>
 
 #include "base/macros.h"
+#include "base/memory/weak_ptr.h"
 
 #include "chromeos/dbus/auth_policy_client.h"
 
 namespace chromeos {
 
 class CHROMEOS_EXPORT FakeAuthPolicyClient : public AuthPolicyClient {
  public:
   FakeAuthPolicyClient();
   ~FakeAuthPolicyClient() override;
 
   // DBusClient overrides.
   void Init(dbus::Bus* bus) override;
   // AuthPolicyClient overrides.
   void JoinAdDomain(const std::string& machine_name,
                     const std::string& user,
                     int password_fd,
                     const JoinCallback& callback) override;
-  void RefreshDevicePolicy(const RefreshPolicyCallback& calllback) override;
+  void RefreshDevicePolicy(const RefreshPolicyCallback& callback) override;
   void RefreshUserPolicy(const std::string& account_id,
-                         const RefreshPolicyCallback& calllback) override;
+                         const RefreshPolicyCallback& callback) override;
 
  private:
+  static int WriteDevicePolicyFile();

[achuithb, 2016/11/30 19:23:34]

We prefer functions in the anonymous namespace in the cc file to private static
fns, as this reduces the linker burden.

[Thiemo Nagel, 2016/11/30 20:06:36]

Done.

+  void OnDevicePolicyFileWritten(const RefreshPolicyCallback& callback,
+                                 int bytes_written);

[achuithb, 2016/11/30 19:23:34]

Let's add a function comment.

[Thiemo Nagel, 2016/11/30 20:06:36]

Done.

+
+  base::WeakPtrFactory<FakeAuthPolicyClient> weak_factory_{this};

[achuithb, 2016/11/30 19:23:34]

Is this allowed by the c++11 guidelines? Have you seen this elsewhere in the
codebase?

I haven't seen it, and I'd rather not have this be the first place. I think it's
kinda cool though.

[Thiemo Nagel, 2016/11/30 20:06:36]

We allow Uniform Initialization Syntax and Non-Static Class Member Initializers.
 All I'm doing is combining the two, afaics.

https://chromium-cpp.appspot.com/
No.
Removed it.  Generally speaking, some place needs to be the first.  What about
starting a thread on chromium-dev?

[achuithb, 2016/11/30 20:22:49]

Personally, I really like this, and would love to see it adopted more widely,
especially for WeakPtrFactory, but I think a thread on chromium-dev should be a
starting point so the persnickety can spend hours debating it. Since this is
your innovation, I think you should propose this?

+
   DISALLOW_COPY_AND_ASSIGN(FakeAuthPolicyClient);
 };
 
 }  // namespace chromeos
 
 #endif  // CHROMEOS_DBUS_FAKE_AUTH_POLICY_CLIENT_H_