MacViews: Fix GlobalKeyboardShortcutsTest.SwitchTabsMac.

ui/views/test/event_generator_delegate_mac.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import <Cocoa/Cocoa.h>
 #include <stddef.h>
 
 #import "base/mac/scoped_nsobject.h"
 #import "base/mac/scoped_objc_class_swizzler.h"
 #include "base/macros.h"
@@ skipping 383 matching lines @@
   NSEvent* ns_event = cocoa_test_event_utils::SynthesizeKeyEvent(
       window_, event->type() == ui::ET_KEY_PRESSED, event->key_code(),
       modifiers, event->is_char() ? event->GetDomKey() : ui::DomKey::NONE);
 
   using Target = ui::test::EventGenerator::Target;
   switch (owner_->target()) {
     case Target::APPLICATION:
       [NSApp sendEvent:ns_event];
       break;
     case Target::WINDOW:
+      // -[NSApp sendEvent:] sends -performKeyEquivalent: if Command or Control
+      // modifiers are pressed. Emulate that behavior.
+      if ([ns_event type] == NSKeyDown &&
+          [ns_event modifierFlags] & (NSControlKeyMask | NSCommandKeyMask) &&

[tapted, 2016/11/28 08:14:18]

nit: extra parens around the bitwise operation

[themblsha, 2016/11/30 12:35:33]

Done. I think performKeyEquivalent: emulation is a useful thing to have here.

[tapted, 2016/11/30 23:52:03]

I agree - I like it too :)

+          [window_ performKeyEquivalent:ns_event])
+        break;  // Handled by performKeyEquivalent:.
+
       [window_ sendEvent:ns_event];
       break;
     case Target::WIDGET:
       if ([fake_menu_ performKeyEquivalent:ns_event])
         return;
 
       EmulateSendEvent(window_, ns_event);
       break;
   }
 }
@@ skipping 195 matching lines @@
 - (NSEvent*)currentEvent {
   if (g_current_event)
     return g_current_event;
 
   // Find the original implementation and invoke it.
   IMP original = EventGeneratorDelegateMac::GetInstance()->CurrentEventMethod();
   return original(self, _cmd);
 }
 
 @end