Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Issue 253103003: ServiceWorker: Initialize member variable in ctor of ServiceWorkerDatabase (Closed)

Created:
6 years, 7 months ago by nhiroki
Modified:
6 years, 7 months ago
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, darin-cc_chromium.org, horo+watch_chromium.org, kinuko+watch, alecflett+watch_chromium.org
Visibility:
Public.

Description

ServiceWorker: Initialize member variable in ctor of ServiceWorkerDatabase BUG=none TEST=content_unittests --gtest_filter=ServiceWorkerDatabase.* (with valgrind) TBR=michaeln@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266811

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M content/browser/service_worker/service_worker_database.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
nhiroki
Let me use TBR. This should fix uninitialized variable access failure on valgrind.
6 years, 7 months ago (2014-04-29 09:37:04 UTC) #1
nhiroki
The CQ bit was checked by nhiroki@chromium.org
6 years, 7 months ago (2014-04-29 09:37:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nhiroki@chromium.org/253103003/1
6 years, 7 months ago (2014-04-29 09:38:47 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 09:42:04 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium
6 years, 7 months ago (2014-04-29 09:42:04 UTC) #5
nhiroki
The CQ bit was checked by nhiroki@chromium.org
6 years, 7 months ago (2014-04-29 09:43:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nhiroki@chromium.org/253103003/1
6 years, 7 months ago (2014-04-29 09:43:41 UTC) #7
nhiroki
6 years, 7 months ago (2014-04-29 09:46:16 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 manually as r266811 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698