Don't create profile in HttpsEngagementMetricsProvider

chrome/browser/metrics/https_engagement_metrics_provider.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/metrics/https_engagement_metrics_provider.h"
 
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/page_load_metrics/observers/https_engagement_metrics/https_engagement_service.h"
 #include "chrome/browser/page_load_metrics/observers/https_engagement_metrics/https_engagement_service_factory.h"
 #include "chrome/browser/profiles/profile_manager.h"
 
 HttpsEngagementMetricsProvider::HttpsEngagementMetricsProvider() {}
 
 HttpsEngagementMetricsProvider::~HttpsEngagementMetricsProvider() {}
 
 void HttpsEngagementMetricsProvider::ProvideGeneralMetrics(
     metrics::ChromeUserMetricsExtension* uma_proto) {
   ProfileManager* profile_manager = g_browser_process->profile_manager();
   if (!profile_manager)
     return;
 
+  Profile* profile = profile_manager->GetProfileByPath(

[Alexei Svitkine (slow), 2016/11/25 18:42:02]

Please add a comment about this.

+      profile_manager->GetLastUsedProfileDir(
+          profile_manager->user_data_dir()));
+  if (!profile)
+    return;
+
   HttpsEngagementService* engagement_service =
-      HttpsEngagementServiceFactory::GetForBrowserContext(
-          profile_manager->GetLastUsedProfile());
+      HttpsEngagementServiceFactory::GetForBrowserContext(profile);
   if (!engagement_service)
     return;
   engagement_service->StoreMetricsAndClear();
 }