Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Unified Diff: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

Issue 2531013002: WebView loadDataWithBaseURL() was determined as a same page navigation (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
index db32736ca58f9d910e5289cb1e3575e669aceafc..842769b737b46729d10e0f8b1ecd2459accf6093 100644
--- a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
+++ b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
@@ -2025,6 +2025,10 @@ void WebLocalFrameImpl::loadData(const WebData& data,
if (replace && !unreachableURL.isEmpty() &&
frame()->loader().provisionalDocumentLoader())
request = frame()->loader().provisionalDocumentLoader()->originalRequest();
+ // TODO(crbug.com/662823): Calling setURL with baseURL is wrong, but Blink
+ // does not provide a right solution to set base URL at loading time now.
+ // This may cause some troubles, e.g. FrameLoader can not detect the same page
+ // navigation correctly as far as we know.
request.setURL(baseURL);
request.setCheckForBrowserSideNavigation(false);

Powered by Google App Engine
This is Rietveld 408576698