Cleanup FWL Event and Message code.

xfa/fwl/core/cfwl_event.h

 // Copyright 2016 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #ifndef XFA_FWL_CORE_CFWL_EVENT_H_
 #define XFA_FWL_CORE_CFWL_EVENT_H_
 
 #include "core/fxcrt/fx_coordinates.h"
 #include "core/fxcrt/fx_string.h"
 #include "core/fxcrt/fx_system.h"
 #include "xfa/fwl/core/cfwl_msgkey.h"
 #include "xfa/fwl/core/cfwl_msgmouse.h"
 #include "xfa/fwl/core/fwl_error.h"
 
 enum class CFWL_EventType {

[Tom Sepez, 2016/12/07 18:48:26]

nit: If I were really compulsive, I'd nest this as CFWL_Event::Type.

[dsinclair, 2016/12/07 20:02:01]

Done.

-  None = 0,
-
   CheckStateChanged,
   CheckWord,
   Click,
   Close,
   EditChanged,
-  Key,
-  KillFocus,
   Mouse,
-  MouseWheel,
   PostDropDown,
   PreDropDown,
   Scroll,
   SelectChanged,
-  SetFocus,
-  SizeChanged,
   TextChanged,
   TextFull,
   Validate
 };
 
 class CFX_Graphics;
 class CFWL_Widget;
 
 class CFWL_Event {
  public:
-  CFWL_Event();
+  explicit CFWL_Event(CFWL_EventType type);

[Tom Sepez, 2016/12/07 18:48:26]

nit: let's add two more ctors:

CFWL_Event(CFWL_EventType type, CFWL_Widget* pSrcTarget);
CFWL_Event(CFWL_EventType type, CFWL_Widget* pSrcTarget, CFWL_Widget*
pDstTarget);

since we nearly always set one or both these immediately after making one.

[dsinclair, 2016/12/07 20:02:01]

Done.

   virtual ~CFWL_Event();
 
-  virtual CFWL_EventType GetClassID() const;
+  CFWL_EventType GetClassID() const { return m_type; }

[Tom Sepez, 2016/12/07 18:48:26]

nit: bad name, maybe GetEventType() ?

[dsinclair, 2016/12/07 20:02:01]

Went with GetType()

 
   CFWL_Widget* m_pSrcTarget;
   CFWL_Widget* m_pDstTarget;
+
+ private:
+  CFWL_EventType m_type;
 };
 
 #endif  // XFA_FWL_CORE_CFWL_EVENT_H_