Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2530943002: Disable guest mode by default if force sign in is enabled. (Closed)

Created:
4 years ago by zmin
Modified:
4 years ago
Reviewers:
pastarmovj, anthonyvd
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable guest mode by default if force sign in is enabled. BUG=642059 Committed: https://crrev.com/f964875454405cb833f64485817670b021d313fc Cr-Commit-Position: refs/heads/master@{#435023}

Patch Set 1 #

Patch Set 2 : fix presubmit warning #

Unified diffs Side-by-side diffs Delta from patch set Stats (+166 lines, -3 lines) Patch
M chrome/browser/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/policy/configuration_policy_handler_list_factory.cc View 1 3 chunks +2 lines, -3 lines 0 comments Download
A chrome/browser/profiles/guest_mode_policy_handler.h View 1 1 chunk +31 lines, -0 lines 0 comments Download
A chrome/browser/profiles/guest_mode_policy_handler.cc View 1 chunk +41 lines, -0 lines 0 comments Download
A chrome/browser/profiles/guest_mode_policy_handler_unittest.cc View 1 chunk +89 lines, -0 lines 0 comments Download
M chrome/test/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 26 (20 generated)
zmin
pastarmovj@chromium.org: Please review changes in chrome/browser/policy/configuration_policy_handler_list_factory.cc anthonyvd@chromium.org: Please review changes in chrome/browser/profiles/* */BUILD.gn
4 years ago (2016-11-24 20:58:05 UTC) #4
anthonyvd
lgtm, thanks for the tests too!
4 years ago (2016-11-28 12:34:06 UTC) #19
pastarmovj
lgtm
4 years ago (2016-11-29 16:36:32 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2530943002/20001
4 years ago (2016-11-29 16:39:47 UTC) #22
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-29 17:35:29 UTC) #24
commit-bot: I haz the power
4 years ago (2016-11-29 17:37:50 UTC) #26
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f964875454405cb833f64485817670b021d313fc
Cr-Commit-Position: refs/heads/master@{#435023}

Powered by Google App Engine
This is Rietveld 408576698