Use unique pointers in CXFA_FMParse

xfa/fxfa/fm2js/xfa_simpleexpression_unittest.cpp

 // Copyright 2016 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "xfa/fxfa/fm2js/xfa_simpleexpression.h"
 
 #include <memory>
+#include <utility>
 
 #include "testing/gtest/include/gtest/gtest.h"
+#include "third_party/base/ptr_util.h"
 #include "xfa/fxfa/fm2js/xfa_lexer.h"
 
 TEST(FMCallExpression, more_than_32_arguments) {
   // Use sign as it has 3 object parameters at positions 0, 5, and 6.
-  std::unique_ptr<CXFA_FMIdentifierExpression> exp(
-      new CXFA_FMIdentifierExpression(0, CFX_WideStringC(L"sign")));
+  std::unique_ptr<CXFA_FMIdentifierExpression> exp =

[Tom Sepez, 2016/11/28 18:09:12]

nit: I'd write auto exp = ...
since we already have the full type information in the MakeUnique<>.
I'm less of a fan of auto when that information isn't immediately obvious ...

[npm, 2016/11/28 20:04:39]

Done.

+      pdfium::MakeUnique<CXFA_FMIdentifierExpression>(0,
+                                                      CFX_WideStringC(L"sign"));

[Tom Sepez, 2016/11/28 18:09:12]

nit: Can we just pass L"sign" (implicit ctor)?

[npm, 2016/11/28 20:04:39]

Done.

 
-  std::unique_ptr<CFX_ArrayTemplate<CXFA_FMSimpleExpression*>> args(
-      new CFX_ArrayTemplate<CXFA_FMSimpleExpression*>());
+  std::vector<std::unique_ptr<CXFA_FMSimpleExpression>> args;
   for (size_t i = 0; i < 50; i++)
-    args->Add(new CXFA_FMSimpleExpression(0, TOKnan));
+    args.push_back(pdfium::MakeUnique<CXFA_FMSimpleExpression>(0, TOKnan));
 
-  CXFA_FMCallExpression callExp(0, exp.release(), args.release(), true);
+  CXFA_FMCallExpression callExp(0, exp.release(), std::move(args), true);
   CFX_WideTextBuf js;
   callExp.ToJavaScript(js);
 
   // Generate the result javascript string.
   CFX_WideString result = L"sign(";
   for (size_t i = 0; i < 50; i++) {
     if (i > 0)
       result += L", ";
 
     result += L"foxit_xfa_formcalc_runtime.get_fm_";
     // Object positions for sign() method.
     if (i == 0 || i == 5 || i == 6)
       result += L"jsobj()";
     else
       result += L"value()";
   }
   result += L")";
 
   EXPECT_EQ(result.AsStringC(), js.AsStringC());
 }