Use unique pointers in CXFA_FMParse

xfa/fxfa/fm2js/xfa_simpleexpression.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "xfa/fxfa/fm2js/xfa_simpleexpression.h"
 
+#include <utility>
+
 #include "core/fxcrt/fx_ext.h"
 
 namespace {
 
 const FX_WCHAR* const gs_lpStrExpFuncName[] = {
     L"foxit_xfa_formcalc_runtime.assign_value_operator",
     L"foxit_xfa_formcalc_runtime.logical_or_operator",
     L"foxit_xfa_formcalc_runtime.logical_and_operator",
     L"foxit_xfa_formcalc_runtime.equality_operator",
     L"foxit_xfa_formcalc_runtime.notequality_operator",
@@ skipping 451 matching lines @@
 void CXFA_FMNotExpression::ToJavaScript(CFX_WideTextBuf& javascript) {
   javascript << gs_lpStrExpFuncName[NOT];
   javascript << FX_WSTRC(L"(");
   m_pExp->ToJavaScript(javascript);
   javascript << FX_WSTRC(L")");
 }
 
 CXFA_FMCallExpression::CXFA_FMCallExpression(
     uint32_t line,
     CXFA_FMSimpleExpression* pExp,
-    CFX_ArrayTemplate<CXFA_FMSimpleExpression*>* pArguments,
+    std::vector<std::unique_ptr<CXFA_FMSimpleExpression>>&& pArguments,
     bool bIsSomMethod)
     : CXFA_FMUnaryExpression(line, TOKcall, pExp),
       m_bIsSomMethod(bIsSomMethod),
-      m_pArguments(pArguments) {}
+      m_Arguments(std::move(pArguments)) {}
 
-CXFA_FMCallExpression::~CXFA_FMCallExpression() {
-  if (m_pArguments) {
-    for (int i = 0; i < m_pArguments->GetSize(); ++i)
-      delete m_pArguments->GetAt(i);
-
-    delete m_pArguments;
-  }
-}
+CXFA_FMCallExpression::~CXFA_FMCallExpression() {}
 
 bool CXFA_FMCallExpression::IsBuildInFunc(CFX_WideTextBuf* funcName) {
   uint32_t uHash = FX_HashCode_GetW(funcName->AsStringC(), true);
   const XFA_FMBuildInFunc* pEnd = g_BuildInFuncs + FX_ArraySize(g_BuildInFuncs);
   const XFA_FMBuildInFunc* pFunc =
       std::lower_bound(g_BuildInFuncs, pEnd, uHash,
                        [](const XFA_FMBuildInFunc& func, uint32_t hash) {
                          return func.m_uHash < hash;
                        });
   if (pFunc < pEnd && uHash == pFunc->m_uHash) {
@@ skipping 26 matching lines @@
   } while (iStart <= iEnd);
   return parameters;
 }
 
 void CXFA_FMCallExpression::ToJavaScript(CFX_WideTextBuf& javascript) {
   CFX_WideTextBuf funcName;
   m_pExp->ToJavaScript(funcName);
   if (m_bIsSomMethod) {
     javascript << funcName;
     javascript << FX_WSTRC(L"(");
-    if (m_pArguments) {
-      uint32_t methodPara = IsMethodWithObjParam(funcName.AsStringC());
-      if (methodPara > 0) {
-        for (int i = 0; i < m_pArguments->GetSize(); ++i) {
-          // Currently none of our expressions use objects for a parameter over
-          // the 6th. Make sure we don't overflow the shift when doing this
-          // check. If we ever need more the 32 object params we can revisit.
-          if (i < 32 && (methodPara & (0x01 << i)) > 0) {
-            javascript << gs_lpStrExpFuncName[GETFMJSOBJ];
-          } else {
-            javascript << gs_lpStrExpFuncName[GETFMVALUE];
-          }
-          javascript << FX_WSTRC(L"(");
-          CXFA_FMSimpleExpression* e = m_pArguments->GetAt(i);
-          e->ToJavaScript(javascript);
-          javascript << FX_WSTRC(L")");
-          if (i + 1 < m_pArguments->GetSize()) {
-            javascript << FX_WSTRC(L", ");
-          }
+    uint32_t methodPara = IsMethodWithObjParam(funcName.AsStringC());
+    if (methodPara > 0) {
+      for (size_t i = 0; i < m_Arguments.size(); ++i) {
+        // Currently none of our expressions use objects for a parameter over
+        // the 6th. Make sure we don't overflow the shift when doing this
+        // check. If we ever need more the 32 object params we can revisit.
+        if (i < 32 && (methodPara & (0x01 << i)) > 0) {

[npm, 2016/11/28 20:04:39]

Leaving i in this for loop for now because it is being used non-trivially.

+          javascript << gs_lpStrExpFuncName[GETFMJSOBJ];
+        } else {
+          javascript << gs_lpStrExpFuncName[GETFMVALUE];
         }
-      } else {
-        for (int i = 0; i < m_pArguments->GetSize(); ++i) {
-          javascript << gs_lpStrExpFuncName[GETFMVALUE];
-          javascript << FX_WSTRC(L"(");
-          CXFA_FMSimpleExpression* e = m_pArguments->GetAt(i);
-          e->ToJavaScript(javascript);
-          javascript << FX_WSTRC(L")");
-          if (i + 1 < m_pArguments->GetSize()) {
-            javascript << FX_WSTRC(L", ");
-          }
+        javascript << FX_WSTRC(L"(");
+        CXFA_FMSimpleExpression* e = m_Arguments.at(i).get();
+        e->ToJavaScript(javascript);
+        javascript << FX_WSTRC(L")");
+        if (i + 1 < m_Arguments.size()) {
+          javascript << FX_WSTRC(L", ");
+        }
+      }
+    } else {
+      for (size_t i = 0; i < m_Arguments.size(); ++i) {
+        javascript << gs_lpStrExpFuncName[GETFMVALUE];
+        javascript << FX_WSTRC(L"(");
+        CXFA_FMSimpleExpression* e = m_Arguments.at(i).get();
+        e->ToJavaScript(javascript);
+        javascript << FX_WSTRC(L")");
+        if (i + 1 < m_Arguments.size()) {
+          javascript << FX_WSTRC(L", ");
         }
       }
     }
     javascript << FX_WSTRC(L")");
   } else {
     bool isEvalFunc = false;
     bool isExistsFunc = false;
     if (IsBuildInFunc(&funcName)) {
       if (funcName.AsStringC() == FX_WSTRC(L"Eval")) {
         isEvalFunc = true;
         javascript << FX_WSTRC(L"eval.call(this, ");
         javascript << gs_lpStrExpFuncName[CALL];
         javascript << FX_WSTRC(L"Translate");
       } else if (funcName.AsStringC() == FX_WSTRC(L"Exists")) {
         isExistsFunc = true;
         javascript << gs_lpStrExpFuncName[CALL];
         javascript << funcName;
       } else {
         javascript << gs_lpStrExpFuncName[CALL];
         javascript << funcName;
       }
     } else {
       javascript << funcName;
     }
     javascript << FX_WSTRC(L"(");
     if (isExistsFunc) {
       javascript << FX_WSTRC(L"\n(\nfunction ()\n{\ntry\n{\n");
-      if (m_pArguments && m_pArguments->GetSize() > 0) {
-        CXFA_FMSimpleExpression* e = m_pArguments->GetAt(0);
+      if (!m_Arguments.empty()) {
+        CXFA_FMSimpleExpression* e = m_Arguments.at(0).get();

[Tom Sepez, 2016/11/28 18:09:12]

nit: same comments as before, also above loops.

         javascript << FX_WSTRC(L"return ");
         e->ToJavaScript(javascript);
         javascript << FX_WSTRC(L";\n}\n");
       } else {
         javascript << FX_WSTRC(L"return 0;\n}\n");
       }
       javascript << FX_WSTRC(
           L"catch(accessExceptions)\n{\nreturn 0;\n}\n}\n).call(this)\n");
-    } else if (m_pArguments) {
-      for (int i = 0; i < m_pArguments->GetSize(); ++i) {
-        CXFA_FMSimpleExpression* e = m_pArguments->GetAt(i);
+    } else {
+      for (size_t i = 0; i < m_Arguments.size(); ++i) {
+        CXFA_FMSimpleExpression* e = m_Arguments.at(i).get();
         e->ToJavaScript(javascript);
-        if (i + 1 < m_pArguments->GetSize()) {
+        if (i + 1 < m_Arguments.size()) {
           javascript << FX_WSTRC(L", ");
         }
       }
     }
     javascript << FX_WSTRC(L")");
     if (isEvalFunc) {
       javascript << FX_WSTRC(L")");
     }
   }
 }
@@ skipping 124 matching lines @@
       L"for(var index = accessor_object.length - 1; index > 1; index--)\n{\n");
   javascript << FX_WSTRC(L"method_return_value = accessor_object[index].");
   m_pExp2->ToJavaScript(javascript);
   javascript << FX_WSTRC(L";\n}\n}\n");
   javascript << FX_WSTRC(L"else\n{\nmethod_return_value = accessor_object.");
   m_pExp2->ToJavaScript(javascript);
   javascript << FX_WSTRC(L";\n}\n");
   javascript << FX_WSTRC(L"return method_return_value;\n");
   javascript << FX_WSTRC(L"}\n).call(this)");
 }