Use unique pointers in CXFA_FMParse

xfa/fxfa/fm2js/xfa_program.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "xfa/fxfa/fm2js/xfa_program.h"
 
+#include <utility>
+#include <vector>
+
+#include "third_party/base/ptr_util.h"
+
 CXFA_FMProgram::CXFA_FMProgram() {}
 
 CXFA_FMProgram::~CXFA_FMProgram() {}
 
 int32_t CXFA_FMProgram::Init(const CFX_WideStringC& wsFormcalc) {
   return m_parse.Init(wsFormcalc, &m_pErrorInfo);
 }
 
 int32_t CXFA_FMProgram::ParseProgram() {
-  CFX_ArrayTemplate<CXFA_FMExpression*>* expressions = nullptr;
   m_parse.NextToken();
   if (!m_pErrorInfo.message.IsEmpty()) {

[Tom Sepez, 2016/11/28 18:09:12]

nit: no {}

[npm, 2016/11/28 20:04:39]

Done.

     return -1;
   }
-  expressions = m_parse.ParseTopExpression();
-  if (!m_pErrorInfo.message.IsEmpty()) {
-    for (int32_t u = 0; u < expressions->GetSize(); ++u)
-      delete expressions->GetAt(u);
+  std::vector<std::unique_ptr<CXFA_FMExpression>> expressions =
+      m_parse.ParseTopExpression();
+  if (!m_pErrorInfo.message.IsEmpty())
+    return -1;
 
-    delete expressions;
-    return -1;
-  }
-  m_globalFunction.reset(
-      new CXFA_FMFunctionDefinition(1, 1, FX_WSTRC(L""), nullptr, expressions));
+  m_globalFunction = pdfium::MakeUnique<CXFA_FMFunctionDefinition>(
+      1, true, FX_WSTRC(L""), nullptr, std::move(expressions));

[Tom Sepez, 2016/11/28 18:09:12]

nit: I think you can just pass L"" here, the ctor should be implicit to avoid
writing this all over the place.

[npm, 2016/11/28 20:04:39]

Done.

   return 0;
 }
 
 int32_t CXFA_FMProgram::TranslateProgram(CFX_WideTextBuf& wsJavaScript) {
   m_globalFunction->ToJavaScript(wsJavaScript);
   wsJavaScript.AppendChar(0);
   return 0;
 }