Web Animations API: Sort keyframes by offset

Source/core/animation/EffectInputTest.cpp

Index: Source/core/animation/EffectInputTest.cpp
diff --git a/Source/core/animation/EffectInputTest.cpp b/Source/core/animation/EffectInputTest.cpp
new file mode 100644
index 0000000000000000000000000000000000000000..f3013287dd157178ff635949c5739553880fb27a
--- /dev/null
+++ b/Source/core/animation/EffectInputTest.cpp
@@ -0,0 +1,125 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "config.h"
+#include "core/animation/EffectInput.h"
+
+#include "bindings/v8/Dictionary.h"
+#include "core/animation/AnimationTestHelper.h"
+#include "core/animation/KeyframeEffectModel.h"
+#include "core/dom/Document.h"
+#include "core/dom/Element.h"
+
+#include <gtest/gtest.h>
+
+using namespace WebCore;
+
+namespace {
+
+class AnimationEffectInputTest : public ::testing::Test {
+protected:
+    AnimationEffectInputTest()
+        : document(Document::create())
+        , element(document->createElement("foo", ASSERT_NO_EXCEPTION))
+        , m_isolate(v8::Isolate::GetCurrent())
+        , m_scope(V8ExecutionScope::create(m_isolate))
+    {
+    }
+
+    RefPtr<Document> document;
+    RefPtr<Element> element;
+    TrackExceptionState exceptionState;
+    v8::Isolate* m_isolate;
+
+private:
+    OwnPtr<V8ExecutionScope> m_scope;
+};
+
+TEST_F(AnimationEffectInputTest, SortedOffsets)
+{
+    Vector<Dictionary> jsKeyframes;
+    v8::Handle<v8::Object> keyframe1 = v8::Object::New(m_isolate);
+    v8::Handle<v8::Object> keyframe2 = v8::Object::New(m_isolate);
+
+    setV8ObjectPropertyAsString(keyframe1, "width", "100px");
+    setV8ObjectPropertyAsString(keyframe1, "offset", "0");
+    setV8ObjectPropertyAsString(keyframe2, "width", "0px");
+    setV8ObjectPropertyAsString(keyframe2, "offset", "1");
+
+    jsKeyframes.append(Dictionary(keyframe1, m_isolate));
+    jsKeyframes.append(Dictionary(keyframe2, m_isolate));
+
+    RefPtrWillBeRawPtr<AnimationEffect> animationEffect = EffectInput::convert(element.get(), jsKeyframes, exceptionState, true);
+    EXPECT_FALSE(exceptionState.hadException());
+    const KeyframeEffectModelBase& keyframeEffect = *toKeyframeEffectModelBase(animationEffect.get());
+    EXPECT_EQ(1.0, keyframeEffect.getFrames()[1]->offset());
+}
+
+TEST_F(AnimationEffectInputTest, UnsortedOffsets)
+{
+    Vector<Dictionary> jsKeyframes;
+    v8::Handle<v8::Object> keyframe1 = v8::Object::New(m_isolate);
+    v8::Handle<v8::Object> keyframe2 = v8::Object::New(m_isolate);
+
+    setV8ObjectPropertyAsString(keyframe1, "width", "0px");
+    setV8ObjectPropertyAsString(keyframe1, "offset", "1");
+    setV8ObjectPropertyAsString(keyframe2, "width", "100px");
+    setV8ObjectPropertyAsString(keyframe2, "offset", "0");
+
+    jsKeyframes.append(Dictionary(keyframe1, m_isolate));
+    jsKeyframes.append(Dictionary(keyframe2, m_isolate));
+
+    RefPtrWillBeRawPtr<AnimationEffect> animationEffect = EffectInput::convert(element.get(), jsKeyframes, exceptionState, true);
+    EXPECT_FALSE(exceptionState.hadException());
+    const KeyframeEffectModelBase& keyframeEffect = *toKeyframeEffectModelBase(animationEffect.get());
+    EXPECT_EQ(1.0, keyframeEffect.getFrames()[1]->offset());
+}
+
+TEST_F(AnimationEffectInputTest, LooslySorted)
+{
+    Vector<Dictionary> jsKeyframes;
+    v8::Handle<v8::Object> keyframe1 = v8::Object::New(m_isolate);
+    v8::Handle<v8::Object> keyframe2 = v8::Object::New(m_isolate);
+    v8::Handle<v8::Object> keyframe3 = v8::Object::New(m_isolate);
+
+    setV8ObjectPropertyAsString(keyframe1, "width", "100px");
+    setV8ObjectPropertyAsString(keyframe1, "offset", "0");
+    setV8ObjectPropertyAsString(keyframe2, "width", "200px");
+    setV8ObjectPropertyAsString(keyframe3, "width", "0px");
+    setV8ObjectPropertyAsString(keyframe3, "offset", "1");
+
+    jsKeyframes.append(Dictionary(keyframe1, m_isolate));
+    jsKeyframes.append(Dictionary(keyframe2, m_isolate));
+    jsKeyframes.append(Dictionary(keyframe3, m_isolate));
+
+    RefPtrWillBeRawPtr<AnimationEffect> animationEffect = EffectInput::convert(element.get(), jsKeyframes, exceptionState, true);
+    EXPECT_FALSE(exceptionState.hadException());
+    const KeyframeEffectModelBase& keyframeEffect = *toKeyframeEffectModelBase(animationEffect.get());
+    EXPECT_EQ(1, keyframeEffect.getFrames()[2]->offset());
+}
+
+TEST_F(AnimationEffectInputTest, Invalid)
+{
+    // Not loosely sorted by offset, and there exists a keyframe with null offset.
+    Vector<Dictionary> jsKeyframes;
+    v8::Handle<v8::Object> keyframe1 = v8::Object::New(m_isolate);
+    v8::Handle<v8::Object> keyframe2 = v8::Object::New(m_isolate);
+    v8::Handle<v8::Object> keyframe3 = v8::Object::New(m_isolate);
+
+    setV8ObjectPropertyAsString(keyframe1, "width", "0px");
+    setV8ObjectPropertyAsString(keyframe1, "offset", "1");
+    setV8ObjectPropertyAsString(keyframe2, "width", "200px");
+    setV8ObjectPropertyAsString(keyframe3, "width", "100px");
+    setV8ObjectPropertyAsString(keyframe3, "offset", "0");
+
+    jsKeyframes.append(Dictionary(keyframe1, m_isolate));
+    jsKeyframes.append(Dictionary(keyframe2, m_isolate));
+    jsKeyframes.append(Dictionary(keyframe3, m_isolate));
+
+    RefPtrWillBeRawPtr<AnimationEffect> animationEffect = EffectInput::convert(element.get(), jsKeyframes, exceptionState, true);
+    EXPECT_TRUE(exceptionState.hadException());
+    EXPECT_EQ(InvalidModificationError, exceptionState.code());
+}
+
+}