Web Animations API: Sort keyframes by offset

Web Animations API: Sort keyframes by offset

EffectInput::convert() was not sorting keyframe offsets properly.
This change updates the conversion code to match spec behaviour [1].

Keyframes that are not loosely sorted and have keyframes with missing
offsets will now throw an InvalidModificationError DOMException.

Null offsets are now properly ignored instead of being interpreted as 0.

Original patch by ericwilligers [2].
This patch uses ScriptValue instead of v8::Value.

[1] https://dvcs.w3.org/hg/FXTF/diff/b5b53c344189/web-animations/index.html
[2] https://codereview.chromium.org/251463003/

BUG=363569
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172864

[alancutter (OOO until 2018), 2014-04-29 09:05:28]

This is a fork of: https://codereview.chromium.org/251463003/

[dstockwell, 2014-04-29 09:10:09]

lgtm

https://codereview.chromium.org/253093002/diff/1/Source/core/animation/Effect...
File Source/core/animation/EffectInput.cpp (right):

https://codereview.chromium.org/253093002/diff/1/Source/core/animation/Effect...
Source/core/animation/EffectInput.cpp:74: if (isNull(offset) || offset < 0 ||
offset > 1)
this should probably use std isnan rather than isnull for clarity

https://codereview.chromium.org/253093002/diff/1/Source/core/animation/Effect...
Source/core/animation/EffectInput.cpp:78: // The JS value null get converted to
0 so we need to check whether the original value is null.
gets

[alancutter (OOO until 2018), 2014-04-29 09:12:23]

https://codereview.chromium.org/253093002/diff/1/Source/core/animation/Effect...
File Source/core/animation/EffectInput.cpp (right):

https://codereview.chromium.org/253093002/diff/1/Source/core/animation/Effect...
Source/core/animation/EffectInput.cpp:74: if (isNull(offset) || offset < 0 ||
offset > 1)
On 2014/04/29 09:10:09, dstockwell wrote:
> this should probably use std isnan rather than isnull for clarity

Done.

https://codereview.chromium.org/253093002/diff/1/Source/core/animation/Effect...
Source/core/animation/EffectInput.cpp:78: // The JS value null get converted to
0 so we need to check whether the original value is null.
On 2014/04/29 09:10:09, dstockwell wrote:
> gets

Done.

[alancutter (OOO until 2018), 2014-04-29 09:12:27]

The CQ bit was checked by alancutter@chromium.org

[commit-bot: I haz the power, 2014-04-29 09:12:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alancutter@chromium.org/253093002/20001

[commit-bot: I haz the power, 2014-04-29 10:34:33]

Change committed as 172864