third_party/WebKit/Source/core/html/HTMLMediaElement.h - Issue 2530883002: Refactor overlay fullscreen video handling into a single callback

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLMediaElement.h

Issue 2530883002: Refactor overlay fullscreen video handling into a single callback (Closed)

Patch Set: rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLMediaElement.h

diff --git a/third_party/WebKit/Source/core/html/HTMLMediaElement.h b/third_party/WebKit/Source/core/html/HTMLMediaElement.h

index 164db457e18362d13235c2c64e4c1da205937ec6..2c9b6bc98bed2ee440b5bf5df6cb41d6ffe494d2 100644

--- a/third_party/WebKit/Source/core/html/HTMLMediaElement.h

+++ b/third_party/WebKit/Source/core/html/HTMLMediaElement.h

@@ -253,6 +253,8 @@ class CORE_EXPORT HTMLMediaElement : public HTMLElement,

bool isFullscreen() const;

void enterFullscreen();

void exitFullscreen();

+ void didEnterFullscreen();

+ void didExitFullscreen();

virtual bool usesOverlayFullscreenVideo() const { return false; }

bool hasClosedCaptions() const;

@@ -351,8 +353,6 @@ class CORE_EXPORT HTMLMediaElement : public HTMLElement,

bool canStartSelection() const override { return false; }

- void didBecomeFullscreenElement() final;

- void willStopBeingFullscreenElement() final;

bool isInteractiveContent() const final;

// ActiveDOMObject functions.