Expected stats list added to promise-based getStats WebRtcBrowserTest.

Expected stats list added to promise-based getStats WebRtcBrowserTest.

Only allow expected/optional stats, fail if any expected stats are
missing. Tests by RTCStats.type, not individual dictionary members.

This helps ensure we have good coverage in the integration test and
helps test against accidentally leaking an unexpected dictionary type.

BUG=627816

[hbos_chromium, 2016-11-24 14:34:40]

The CQ bit was checked by hbos@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-24 14:35:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hbos_chromium, 2016-11-24 14:35:55]

hbos@chromium.org changed reviewers:
+ hta@chromium.org

[hbos_chromium, 2016-11-24 14:35:55]

Please take a look, hta.

This is a simpler but less robust blink layer browser test for stats types.

[commit-bot: I haz the power, 2016-11-24 15:21:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-24 15:21:35]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[hta - Chromium, 2016-11-24 15:45:00]

lgtm
I think this is a beautiful test, and tests exactly the right thing! Go for it!

https://codereview.chromium.org/2530873002/diff/1/chrome/test/data/webrtc/pee...
File chrome/test/data/webrtc/peerconnection_getstats.js (right):

https://codereview.chromium.org/2530873002/diff/1/chrome/test/data/webrtc/pee...
chrome/test/data/webrtc/peerconnection_getstats.js:7: var kExpectedStats = [
Naming nits: I'd call this "kMustHaveStats" (could call it "mandatory", but
that's used for so many other things).

[hbos_chromium, 2016-11-25 10:56:44]

I landed https://codereview.chromium.org/2489673003/ in favor of this. They're
modifying the same test. While both tests could be kept, the landed CL tests the
same thing this one does (and more), so having this becomes pointless.

The reason for this is I think having test coverage for dictionary members, not
just dictionary types, is worth the cost.

[hbos_chromium, 2016-11-25 10:57:34]

Description was changed from

==========
Expected stats list added to promise-based getStats WebRtcBrowserTest.

Only allow expected/optional stats, fail if any expected stats are
missing. Tests by RTCStats.type, not individual dictionary members.

This helps ensure we have good coverage in the integration test and
helps test against accidentally leaking an unexpected dictionary type.

BUG=627816
==========

to

==========
Expected stats list added to promise-based getStats WebRtcBrowserTest.

Only allow expected/optional stats, fail if any expected stats are
missing. Tests by RTCStats.type, not individual dictionary members.

This helps ensure we have good coverage in the integration test and
helps test against accidentally leaking an unexpected dictionary type.

BUG=627816
==========

[hta - Chromium, 2016-11-26 08:09:07]

On 2016/11/25 10:56:44, hbos_chromium wrote:
> I landed https://codereview.chromium.org/2489673003/ in favor of this. They're
> modifying the same test. While both tests could be kept, the landed CL tests
the
> same thing this one does (and more), so having this becomes pointless.
> 
> The reason for this is I think having test coverage for dictionary members,
not
> just dictionary types, is worth the cost.

Looking at both, I agree. Please close this CL without landing.