third_party/WebKit/Source/web/tests/WebViewTest.cpp - Issue 2530843003: Introduce InsertIncrementalTextCommand to respect existing style for composition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/WebViewTest.cpp

Issue 2530843003: Introduce InsertIncrementalTextCommand to respect existing style for composition (Closed)

Patch Set: Add a test for commitText() Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/tests/WebViewTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/WebViewTest.cpp b/third_party/WebKit/Source/web/tests/WebViewTest.cpp

index 3cb8d703df557a0d9e11c8eb3c091be0f6efc834..0dca2ad79f28887c986ec20e3e4fdb86d03ec27d 100644

--- a/third_party/WebKit/Source/web/tests/WebViewTest.cpp

+++ b/third_party/WebKit/Source/web/tests/WebViewTest.cpp

@@ -1280,7 +1280,7 @@ TEST_P(WebViewTest, FinishCompositionDoesNotRevealSelection) {

Vector<CompositionUnderline> emptyUnderlines;

WebLocalFrameImpl* frame = webView->mainFrameImpl();

frame->frame()->inputMethodController().setCompositionFromExistingText(

- emptyUnderlines, 3, 3);

+ emptyUnderlines, 0, 3);

// Scroll the input field out of the viewport.

Element* element = static_cast<Element*>(