content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java - Issue 2530843003: Introduce InsertIncrementalTextCommand to respect existing style for composition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java

Issue 2530843003: Introduce InsertIncrementalTextCommand to respect existing style for composition (Closed)

Patch Set: Add a test for commitText() Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/events/ime-composition-events-001.html » ('j') | third_party/WebKit/Source/core/editing/InputMethodController.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java

diff --git a/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java b/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java

index 52bfd210131e7df849cf0926dc6bc62c84d9a82a..f39314b8cf0e957aea99b99f24b7912ad0980e29 100644

--- a/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java

+++ b/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java

@@ -1275,7 +1275,7 @@ public class ImeTest extends ContentShellTestBase {

// TODO(changwan): reduce the number of selection changes

waitForEventLogs("keydown(229),compositionstart(),compositionupdate(a),input,keyup(229),"

+ "compositionupdate(a),input,compositionend(a),selectionchange,selectionchange,"

- + "selectionchange,selectionchange,selectionchange");

+ + "selectionchange,selectionchange,selectionchange,selectionchange");

}

@MediumTest

@@ -1291,7 +1291,8 @@ public class ImeTest extends ContentShellTestBase {

// TODO(changwan): reduce the number of selection changes

waitForEventLogs("keydown(229),compositionstart(),compositionupdate(a),"

+ "input,keyup(229),compositionupdate(a),input,compositionend(a),selectionchange,"

- + "selectionchange,selectionchange,selectionchange,selectionchange");

+ + "selectionchange,selectionchange,selectionchange,selectionchange,"

+ + "selectionchange");

}

@MediumTest