third_party/WebKit/Source/core/editing/commands/InsertTextCommand.h - Issue 2530843003: Introduce InsertIncrementalTextCommand to respect existing style for composition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/InsertTextCommand.h

Issue 2530843003: Introduce InsertIncrementalTextCommand to respect existing style for composition (Closed)

Patch Set: Address xiaochengh@'s review Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/InsertIncrementalTextCommand.cpp ('k') | third_party/WebKit/Source/core/editing/commands/TypingCommand.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/InsertTextCommand.h

diff --git a/third_party/WebKit/Source/core/editing/commands/InsertTextCommand.h b/third_party/WebKit/Source/core/editing/commands/InsertTextCommand.h

index dccb65a08217ab76ab5f8a6ba172859ddcb9afdd..62b041dac65104da1f8a6d0d73f05aeced9e8d4a 100644

--- a/third_party/WebKit/Source/core/editing/commands/InsertTextCommand.h

+++ b/third_party/WebKit/Source/core/editing/commands/InsertTextCommand.h

@@ -30,7 +30,7 @@

namespace blink {

-class InsertTextCommand final : public CompositeEditCommand {

+class InsertTextCommand : public CompositeEditCommand {

public:

enum RebalanceType {

RebalanceLeadingAndTrailingWhitespaces,

@@ -48,7 +48,7 @@ class InsertTextCommand final : public CompositeEditCommand {

String textDataForInputEvent() const final;

- private:

+ protected:

InsertTextCommand(Document&,

const String& text,

bool selectInsertedText,