third_party/WebKit/Source/core/editing/InputMethodController.h - Issue 2530843003: Introduce InsertIncrementalTextCommand to respect existing style for composition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/InputMethodController.h

Issue 2530843003: Introduce InsertIncrementalTextCommand to respect existing style for composition (Closed)

Patch Set: Address xiaochengh@'s review Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/InputMethodController.h

diff --git a/third_party/WebKit/Source/core/editing/InputMethodController.h b/third_party/WebKit/Source/core/editing/InputMethodController.h

index d8bd02379cb406f83a1a4db574d7d8d184e19290..1f40c79bca80b0b68f61e94b9323e875191c5c67 100644

--- a/third_party/WebKit/Source/core/editing/InputMethodController.h

+++ b/third_party/WebKit/Source/core/editing/InputMethodController.h

@@ -109,7 +109,6 @@ class CORE_EXPORT InputMethodController final

Member<LocalFrame> m_frame;

Member<Range> m_compositionRange;

- bool m_isDirty;

bool m_hasComposition;

explicit InputMethodController(LocalFrame&);

@@ -142,10 +141,6 @@ class CORE_EXPORT InputMethodController final

PlainTextRange createSelectionRangeForSetComposition(int selectionStart,

int selectionEnd,

size_t textLength) const;

- void setCompositionWithIncrementalText(const String&,

- const Vector<CompositionUnderline>&,

- int selectionStart,

- int selectionEnd);

int textInputFlags() const;

WebTextInputMode inputModeOfFocusedElement() const;