Start authpolicyd

chrome/browser/chromeos/policy/browser_policy_connector_chromeos.cc

Index: chrome/browser/chromeos/policy/browser_policy_connector_chromeos.cc
diff --git a/chrome/browser/chromeos/policy/browser_policy_connector_chromeos.cc b/chrome/browser/chromeos/policy/browser_policy_connector_chromeos.cc
index 82fa3d3d51d5f14880bb32c22b73579d767a3ac2..74ee2e09b55fe1dd9f5b6d3e1af88252d9a4bf8b 100644
--- a/chrome/browser/chromeos/policy/browser_policy_connector_chromeos.cc
+++ b/chrome/browser/chromeos/policy/browser_policy_connector_chromeos.cc
@@ -45,6 +45,7 @@
 #include "chromeos/cryptohome/system_salt_getter.h"
 #include "chromeos/dbus/cryptohome_client.h"
 #include "chromeos/dbus/dbus_thread_manager.h"
+#include "chromeos/dbus/upstart_client.h"
 #include "chromeos/network/network_handler.h"
 #include "chromeos/network/onc/onc_certificate_importer_impl.h"
 #include "chromeos/settings/cros_settings_names.h"
@@ -110,6 +111,14 @@ BrowserPolicyConnectorChromeOS::BrowserPolicyConnectorChromeOS()
             GetBackgroundTaskRunner());
 
     if (install_attributes_->IsActiveDirectoryManaged()) {
+      chromeos::DBusThreadManager* thread_manager =
+          chromeos::DBusThreadManager::Get();
+      DCHECK(thread_manager);

[Alexander Alekseev, 2016/12/01 09:02:20]

nit: remove DCHECK

According to
https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++.md...
:

- A consequence of this is that you should not handle DCHECK() failures, even if
failure would result in a crash. 

[Roman Sorokin (ftl), 2016/12/01 13:18:56]

Done.

[Thiemo Nagel, 2016/12/01 13:33:51]

I'm fine with removing the DCHECK(), but just for the record, what you write is
not the intention of "you should not handle DCHECK() failure".

// Good.
DCHECK(ptr);
ptr->DoSomething();

// Bad.  You should not handle DCHECK() failure.
DCHECK(ptr);
if (ptr)
  ptr->DoSomething();

[Alexander Alekseev, 2016/12/02 01:10:34]

Yes, I actually agree with you. I just got used to "never DCHECK pointers if it
is going to crash on the next line". But we can put it back if you think (as
owner) that they are helpful here.

+      chromeos::UpstartClient* upstart_client =
+          thread_manager->GetUpstartClient();
+      DCHECK(upstart_client);

[Alexander Alekseev, 2016/12/01 09:02:20]

Ditto.

[Roman Sorokin (ftl), 2016/12/01 13:18:56]

Done.

+      upstart_client->StartAuthPolicyService();
+
       device_active_directory_policy_manager_ =
           new DeviceActiveDirectoryPolicyManager(
               std::move(device_cloud_policy_store));