Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(724)

Issue 2530803002: Revert of Use parenthesis in descriptions for array/map/set lengths/sizes (Closed)

Created:
4 years ago by Michael Achenbach
Modified:
4 years ago
Reviewers:
kozy, dgozman, luoe
CC:
v8-reviews_googlegroups.com, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Use parenthesis in descriptions for array/map/set lengths/sizes (patchset #3 id:40001 of https://codereview.chromium.org/2521853003/ ) Reason for revert: Breaks layout tests: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/11595 https://github.com/v8/v8/wiki/Blink-layout-tests Original issue's description: > Use parenthesis in descriptions for array/map/set lengths/sizes > > Descriptions for (typed)arrays will use parenthesis instead of square brackets > "Array(10)" instead of "Array[10]". This CL also adds size hints to descriptions > of maps and sets. > > Related CL for DevTools: https://codereview.chromium.org/2524913002/ > > BUG=405845 > > Committed: https://crrev.com/92c77a57390e6a9ef726535b255a24359751992d > Cr-Commit-Position: refs/heads/master@{#41237} TBR=dgozman@chromium.org,kozyatinskiy@chromium.org,luoe@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=405845 Committed: https://crrev.com/5e3e29d919aa7f64e2c12c88ecdfd1b00acbe64a Cr-Commit-Position: refs/heads/master@{#41243}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -56 lines) Patch
M src/inspector/injected-script-source.js View 1 chunk +1 line, -7 lines 0 comments Download
M test/inspector/debugger/object-preview-internal-properties-expected.txt View 3 chunks +4 lines, -5 lines 0 comments Download
D test/inspector/runtime/length-or-size-description.js View 1 chunk +0 lines, -23 lines 0 comments Download
D test/inspector/runtime/length-or-size-description-expected.txt View 1 chunk +0 lines, -17 lines 0 comments Download
M test/inspector/runtime/set-or-map-entries-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Michael Achenbach
Created Revert of Use parenthesis in descriptions for array/map/set lengths/sizes
4 years ago (2016-11-24 07:21:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2530803002/1
4 years ago (2016-11-24 07:21:58 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-24 07:22:14 UTC) #6
commit-bot: I haz the power
4 years ago (2016-11-24 07:22:37 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5e3e29d919aa7f64e2c12c88ecdfd1b00acbe64a
Cr-Commit-Position: refs/heads/master@{#41243}

Powered by Google App Engine
This is Rietveld 408576698