Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 2530773002: [turbofan] Improve typed lowering rules for JSToBoolean. (Closed)

Created:
4 years ago by Benedikt Meurer
Modified:
4 years ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Improve typed lowering rules for JSToBoolean. Also lower JSToBoolean(x) where x is either some detectable receiver or null, or any kind of receiver, null or undefined. Also fix a couple of minor issues with the JSToBoolean lowering and tests. R=yangguo@chromium.org BUG=v8:5267 Committed: https://crrev.com/9da894edcbbcb24bf884df32338609771fdd87fa Cr-Commit-Position: refs/heads/master@{#41241}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -38 lines) Patch
M src/compiler/js-typed-lowering.cc View 2 chunks +16 lines, -2 lines 0 comments Download
M src/compiler/types.h View 1 chunk +2 lines, -0 lines 0 comments Download
M test/unittests/compiler/graph-unittest.h View 1 chunk +1 line, -0 lines 0 comments Download
M test/unittests/compiler/graph-unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 2 chunks +20 lines, -1 line 0 comments Download
M test/unittests/compiler/node-test-utils.h View 2 chunks +2 lines, -2 lines 0 comments Download
M test/unittests/compiler/node-test-utils.cc View 4 chunks +2 lines, -33 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Benedikt Meurer
4 years ago (2016-11-24 05:26:20 UTC) #1
Yang
On 2016/11/24 05:26:20, Benedikt Meurer wrote: lgtm.
4 years ago (2016-11-24 06:32:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2530773002/1
4 years ago (2016-11-24 06:34:31 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-24 06:36:52 UTC) #10
commit-bot: I haz the power
4 years ago (2016-11-24 06:37:23 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9da894edcbbcb24bf884df32338609771fdd87fa
Cr-Commit-Position: refs/heads/master@{#41241}

Powered by Google App Engine
This is Rietveld 408576698