Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: ash/common/system/chromeos/network/network_list_md.h

Issue 2530763002: [ash-md] Adjusts layout of lists with sticky header rows to match specs (Closed)
Patch Set: [ash-md] Adjusts layout of lists with sticky header rows to match specs (rebased) Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/common/system/chromeos/network/network_list_md.h
diff --git a/ash/common/system/chromeos/network/network_list_md.h b/ash/common/system/chromeos/network/network_list_md.h
index bbf8f5567a689e1fd1d33286985eb6a19553dc1a..3df22287d388ff4a70058ae7c51ccc4ba484e57a 100644
--- a/ash/common/system/chromeos/network/network_list_md.h
+++ b/ash/common/system/chromeos/network/network_list_md.h
@@ -21,6 +21,7 @@
namespace views {
class Label;
+class Separator;
class View;
}
@@ -91,11 +92,12 @@ class NetworkListViewMd : public NetworkListViewBase,
// Creates a cellular/Wi-Fi header row |view| and adds it to |container()| if
// necessary and reorders the |container()| placing the |view| at
- // |child_index|.
- void UpdateSectionHeaderRow(chromeos::NetworkTypePattern pattern,
- bool enabled,
- int child_index,
- SectionHeaderRowView** view);
+ // |child_index|. Returns the last occupied child index.
tdanderson 2016/11/24 23:37:53 I think the comment you've added should instead re
varkha 2016/11/28 17:14:39 Done.
+ int UpdateSectionHeaderRow(chromeos::NetworkTypePattern pattern,
+ bool enabled,
+ int child_index,
+ SectionHeaderRowView** view,
+ views::Separator** separator_view);
// network_icon::AnimationObserver:
void NetworkIconChanged() override;
@@ -107,6 +109,8 @@ class NetworkListViewMd : public NetworkListViewBase,
views::Label* no_cellular_networks_view_;
SectionHeaderRowView* cellular_header_view_;
SectionHeaderRowView* wifi_header_view_;
+ views::Separator* cellular_separator_view_;
+ views::Separator* wifi_separator_view_;
// An owned list of network info.
std::vector<std::unique_ptr<NetworkInfo>> network_list_;

Powered by Google App Engine
This is Rietveld 408576698