Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Unified Diff: ash/common/system/chromeos/network/network_list_md.h

Issue 2530763002: [ash-md] Adjusts layout of lists with sticky header rows to match specs (Closed)
Patch Set: [ash-md] Adjusts layout of lists with sticky header rows to match specs (cleanup of shill) Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ash/common/system/chromeos/network/network_list_md.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/common/system/chromeos/network/network_list_md.h
diff --git a/ash/common/system/chromeos/network/network_list_md.h b/ash/common/system/chromeos/network/network_list_md.h
index bbf8f5567a689e1fd1d33286985eb6a19553dc1a..d99243a898a2fe35a1287a51ba79194079580c40 100644
--- a/ash/common/system/chromeos/network/network_list_md.h
+++ b/ash/common/system/chromeos/network/network_list_md.h
@@ -21,6 +21,7 @@
namespace views {
class Label;
+class Separator;
class View;
}
@@ -91,11 +92,13 @@ class NetworkListViewMd : public NetworkListViewBase,
// Creates a cellular/Wi-Fi header row |view| and adds it to |container()| if
// necessary and reorders the |container()| placing the |view| at
- // |child_index|.
- void UpdateSectionHeaderRow(chromeos::NetworkTypePattern pattern,
- bool enabled,
- int child_index,
- SectionHeaderRowView** view);
+ // |child_index|. Returns the index where the next child should be inserted,
+ // i.e., the index directly after the last inserted child.
+ int UpdateSectionHeaderRow(chromeos::NetworkTypePattern pattern,
+ bool enabled,
+ int child_index,
+ SectionHeaderRowView** view,
+ views::Separator** separator_view);
// network_icon::AnimationObserver:
void NetworkIconChanged() override;
@@ -107,6 +110,8 @@ class NetworkListViewMd : public NetworkListViewBase,
views::Label* no_cellular_networks_view_;
SectionHeaderRowView* cellular_header_view_;
SectionHeaderRowView* wifi_header_view_;
+ views::Separator* cellular_separator_view_;
+ views::Separator* wifi_separator_view_;
// An owned list of network info.
std::vector<std::unique_ptr<NetworkInfo>> network_list_;
« no previous file with comments | « no previous file | ash/common/system/chromeos/network/network_list_md.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698