Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 2530713002: Mark PaymentDetails.error as experimental (Closed)

Created:
4 years ago by please use gerrit instead
Modified:
4 years ago
Reviewers:
Rick Byers
CC:
blink-reviews, chromium-reviews, haraken, rouslan+payments_chromium.org, sebsg+paymentswatch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mark PaymentDetails.error as experimental There has not been a request to implement and ship this feature, so it should be marked as experimental until such request has been sent out and consequently approved. BUG=648240 Committed: https://crrev.com/1f7a87077603d65b6ac7d2cbf6dca8a3bff8ec87 Cr-Commit-Position: refs/heads/master@{#434664}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M third_party/WebKit/Source/modules/payments/PaymentDetails.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
please use gerrit instead
Rick, ptal.
4 years ago (2016-11-23 21:44:28 UTC) #3
Rick Byers
lgtm
4 years ago (2016-11-25 00:03:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2530713002/1
4 years ago (2016-11-26 23:11:38 UTC) #9
commit-bot: I haz the power
Failed to apply patch for third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in: While running git apply --index -p1; error: patch failed: ...
4 years ago (2016-11-27 02:08:43 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2530713002/20001
4 years ago (2016-11-28 14:57:28 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-28 16:30:11 UTC) #16
commit-bot: I haz the power
4 years ago (2016-11-28 16:34:03 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1f7a87077603d65b6ac7d2cbf6dca8a3bff8ec87
Cr-Commit-Position: refs/heads/master@{#434664}

Powered by Google App Engine
This is Rietveld 408576698