Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2530663002: Fix for DragEnd event being sent with the wrong coordinates. (Closed)

Created:
4 years ago by paulmeyer
Modified:
4 years ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, site-isolation-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix for DragEnd event being sent with the wrong coordinates. This event was accidentally sent with (x, x) instead of (x, y). This patch corrects this. BUG=667963 Committed: https://crrev.com/94c098de407049a62aebef939cb7ce93200a5139 Cr-Commit-Position: refs/heads/master@{#434295}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/browser/web_contents/web_contents_view_aura.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
paulmeyer
4 years ago (2016-11-23 19:25:47 UTC) #3
Charlie Reis
lukasza@, you have a test that covers this, right? LGTM.
4 years ago (2016-11-23 20:37:08 UTC) #5
Łukasz Anforowicz
On 2016/11/23 20:37:08, Charlie Reis (slow) wrote: > lukasza@, you have a test that covers ...
4 years ago (2016-11-23 20:39:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2530663002/1
4 years ago (2016-11-23 20:42:44 UTC) #8
ncarter (slow)
lgtm
4 years ago (2016-11-23 21:17:19 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-24 00:20:57 UTC) #12
commit-bot: I haz the power
4 years ago (2016-11-24 00:23:31 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/94c098de407049a62aebef939cb7ce93200a5139
Cr-Commit-Position: refs/heads/master@{#434295}

Powered by Google App Engine
This is Rietveld 408576698