Revert of [Mac] Switch from NSObject categories to forward declarations for Touch Bar support. (pat…

Revert of [Mac] Switch from NSObject categories to forward declarations for Touch Bar support. (patchset #4 id:100001 of https://codereview.chromium.org/2519563002/ )

Reason for revert:
Persistent build failures on official.desktop (see http://crbug.com/667830)

Breaks compilation with the 10.12.1 SDK:
bridged_content_view_touch_bar.mm:50:4: error: 'NSTouchBarItem' is partial: introduced in macOS 10.12.1 [-Werror,-Wunguarded-availability]

Also tapted doesn't like the macros.

Original issue's description:
> [Mac] Switch from NSObject categories to forward declarations for Touch Bar support.
>
> This fixes a crash when -[BridgedContentView touchBar:] calls
> -[NSGroupTouchBarItem groupItemWithIdentifier:items:], because
> NSGroupTouchBarItem was typedef'd to NSObject.
>
> BUG=666893
>
> Committed: https://crrev.com/799f1635ddedf7fd2f69f7dca26b0f2bf6399cba
> Cr-Commit-Position: refs/heads/master@{#433558}

TBR=sdy@chromium.org,tapted@chromium.org
BUG=666893, 667830
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2526723002
Cr-Commit-Position: refs/heads/master@{#434125}
(cherry picked from commit ad8fde91632a1de9759cf18404c6755d815c48aa)

[Sidney San Martín, 2016-11-23 18:37:41]

Description was changed from

==========
Revert of [Mac] Switch from NSObject categories to forward declarations for
Touch Bar support. (patchset #4 id:100001 of
https://codereview.chromium.org/2519563002/ )

Reason for revert:
Persistent build failures on official.desktop (see http://crbug.com/667830)

Breaks compilation with the 10.12.1 SDK:
bridged_content_view_touch_bar.mm:50:4: error: 'NSTouchBarItem' is partial:
introduced in macOS 10.12.1 [-Werror,-Wunguarded-availability]

Also tapted doesn't like the macros.

Original issue's description:
> [Mac] Switch from NSObject categories to forward declarations for Touch Bar
support.
>
> This fixes a crash when -[BridgedContentView touchBar:] calls
> -[NSGroupTouchBarItem groupItemWithIdentifier:items:], because
> NSGroupTouchBarItem was typedef'd to NSObject.
>
> BUG=666893
>
> Committed: https://crrev.com/799f1635ddedf7fd2f69f7dca26b0f2bf6399cba
> Cr-Commit-Position: refs/heads/master@{#433558}

TBR=sdy@chromium.org
BUG=666893, 667830

Review-Url: https://codereview.chromium.org/2526723002
Cr-Commit-Position: refs/heads/master@{#434125}
(cherry picked from commit ad8fde91632a1de9759cf18404c6755d815c48aa)
==========

to

==========
Revert of [Mac] Switch from NSObject categories to forward declarations for
Touch Bar support. (patchset #4 id:100001 of
https://codereview.chromium.org/2519563002/ )

Reason for revert:
Persistent build failures on official.desktop (see http://crbug.com/667830)

Breaks compilation with the 10.12.1 SDK:
bridged_content_view_touch_bar.mm:50:4: error: 'NSTouchBarItem' is partial:
introduced in macOS 10.12.1 [-Werror,-Wunguarded-availability]

Also tapted doesn't like the macros.

Original issue's description:
> [Mac] Switch from NSObject categories to forward declarations for Touch Bar
support.
>
> This fixes a crash when -[BridgedContentView touchBar:] calls
> -[NSGroupTouchBarItem groupItemWithIdentifier:items:], because
> NSGroupTouchBarItem was typedef'd to NSObject.
>
> BUG=666893
>
> Committed: https://crrev.com/799f1635ddedf7fd2f69f7dca26b0f2bf6399cba
> Cr-Commit-Position: refs/heads/master@{#433558}

TBR=sdy@chromium.org,tapted@chromium.org
BUG=666893, 667830

Review-Url: https://codereview.chromium.org/2526723002
Cr-Commit-Position: refs/heads/master@{#434125}
(cherry picked from commit ad8fde91632a1de9759cf18404c6755d815c48aa)
==========

[Sidney San Martín, 2016-11-23 18:37:54]

The CQ bit was checked by sdy@chromium.org

[commit-bot: I haz the power, 2016-11-23 18:38:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 18:38:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-23 18:38:28]

CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true
and NOPRESUBMIT=true in order for the CQ to process them

[Sidney San Martín, 2016-11-23 18:39:07]

Description was changed from

==========
Revert of [Mac] Switch from NSObject categories to forward declarations for
Touch Bar support. (patchset #4 id:100001 of
https://codereview.chromium.org/2519563002/ )

Reason for revert:
Persistent build failures on official.desktop (see http://crbug.com/667830)

Breaks compilation with the 10.12.1 SDK:
bridged_content_view_touch_bar.mm:50:4: error: 'NSTouchBarItem' is partial:
introduced in macOS 10.12.1 [-Werror,-Wunguarded-availability]

Also tapted doesn't like the macros.

Original issue's description:
> [Mac] Switch from NSObject categories to forward declarations for Touch Bar
support.
>
> This fixes a crash when -[BridgedContentView touchBar:] calls
> -[NSGroupTouchBarItem groupItemWithIdentifier:items:], because
> NSGroupTouchBarItem was typedef'd to NSObject.
>
> BUG=666893
>
> Committed: https://crrev.com/799f1635ddedf7fd2f69f7dca26b0f2bf6399cba
> Cr-Commit-Position: refs/heads/master@{#433558}

TBR=sdy@chromium.org,tapted@chromium.org
BUG=666893, 667830

Review-Url: https://codereview.chromium.org/2526723002
Cr-Commit-Position: refs/heads/master@{#434125}
(cherry picked from commit ad8fde91632a1de9759cf18404c6755d815c48aa)
==========

to

==========
Revert of [Mac] Switch from NSObject categories to forward declarations for
Touch Bar support. (patchset #4 id:100001 of
https://codereview.chromium.org/2519563002/ )

Reason for revert:
Persistent build failures on official.desktop (see http://crbug.com/667830)

Breaks compilation with the 10.12.1 SDK:
bridged_content_view_touch_bar.mm:50:4: error: 'NSTouchBarItem' is partial:
introduced in macOS 10.12.1 [-Werror,-Wunguarded-availability]

Also tapted doesn't like the macros.

Original issue's description:
> [Mac] Switch from NSObject categories to forward declarations for Touch Bar
support.
>
> This fixes a crash when -[BridgedContentView touchBar:] calls
> -[NSGroupTouchBarItem groupItemWithIdentifier:items:], because
> NSGroupTouchBarItem was typedef'd to NSObject.
>
> BUG=666893
>
> Committed: https://crrev.com/799f1635ddedf7fd2f69f7dca26b0f2bf6399cba
> Cr-Commit-Position: refs/heads/master@{#433558}

TBR=sdy@chromium.org,tapted@chromium.org
BUG=666893, 667830
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2526723002
Cr-Commit-Position: refs/heads/master@{#434125}
(cherry picked from commit ad8fde91632a1de9759cf18404c6755d815c48aa)
==========

[Sidney San Martín, 2016-11-23 18:39:10]

The CQ bit was checked by sdy@chromium.org

[commit-bot: I haz the power, 2016-11-23 18:39:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 18:44:26]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1479926350617280, "parent_rev":
"640c4b470ceb4fb0c0b098fa9a64db9afda529bf", "commit_rev":
"c9506a4b5366f691db083031cdc05ab02dc6e8ef"}

[commit-bot: I haz the power, 2016-11-23 18:44:54]

Committed patchset #1 (id:1)