Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Unified Diff: media/mojo/services/mojo_renderer_service.cc

Issue 2530613003: media: Fix lifetime of InterfaceFactoryImpl and created impls (Closed)
Patch Set: comments addressed Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/mojo/services/mojo_renderer_service.cc
diff --git a/media/mojo/services/mojo_renderer_service.cc b/media/mojo/services/mojo_renderer_service.cc
index 5cd986ef3eac7cc1b885c21ae7a71bf1366fd16e..120328a3c3701422cab7674171e9f4a648936e9d 100644
--- a/media/mojo/services/mojo_renderer_service.cc
+++ b/media/mojo/services/mojo_renderer_service.cc
@@ -285,9 +285,11 @@ void MojoRendererService::InitiateScopedSurfaceRequest(
// This may cause |this| to be destructed.
DCHECK(!bad_message_cb_.is_null());
bad_message_cb_.Run();
+
return;
}
callback.Run(initiate_surface_request_cb_.Run());
}
+
} // namespace media

Powered by Google App Engine
This is Rietveld 408576698