Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(797)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: media/mojo/services/mojo_renderer_service.h

Issue 2530613003: media: Fix lifetime of InterfaceFactoryImpl and created impls (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/mojo/services/interface_factory_impl.cc ('k') | media/mojo/services/mojo_renderer_service.cc » ('j') | media/mojo/services/mojo_renderer_service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/mojo/services/mojo_renderer_service.h
diff --git a/media/mojo/services/mojo_renderer_service.h b/media/mojo/services/mojo_renderer_service.h
index ea4e9377f0c1474646a463fa49e731fb2557d410..11c7b96f8f86711081b224712e3039be98284e30 100644
--- a/media/mojo/services/mojo_renderer_service.h
+++ b/media/mojo/services/mojo_renderer_service.h
@@ -78,6 +78,7 @@ class MEDIA_MOJO_EXPORT MojoRendererService
STATE_ERROR
};
+ public:
xhwang 2016/11/23 22:27:09 This is a hack, I'll fix it.
xhwang 2016/11/29 10:20:57 Done.
MojoRendererService(
base::WeakPtr<MojoCdmServiceContext> mojo_cdm_service_context,
scoped_refptr<AudioRendererSink> audio_sink,
@@ -85,6 +86,7 @@ class MEDIA_MOJO_EXPORT MojoRendererService
std::unique_ptr<media::Renderer> renderer,
InitiateSurfaceRequestCB initiate_surface_request_cb);
+ private:
// RendererClient implementation.
void OnError(PipelineStatus status) final;
void OnEnded() final;
« no previous file with comments | « media/mojo/services/interface_factory_impl.cc ('k') | media/mojo/services/mojo_renderer_service.cc » ('j') | media/mojo/services/mojo_renderer_service.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698