content/public/common/content_descriptors.h - Issue 2530573002: Share field trial allocator on zygote-using Linuxes

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/public/common/content_descriptors.h

Issue 2530573002: Share field trial allocator on zygote-using Linuxes (Closed)

Patch Set: git rebase-update Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« components/variations/child_process_field_trial_syncer_unittest.cc ('K') | « content/browser/child_process_launcher.cc ('k') | content/public/test/render_view_test.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CONTENT_PUBLIC_COMMON_CONTENT_DESCRIPTORS_H_	5 #ifndef CONTENT_PUBLIC_COMMON_CONTENT_DESCRIPTORS_H_

6 #define CONTENT_PUBLIC_COMMON_CONTENT_DESCRIPTORS_H_	6 #define CONTENT_PUBLIC_COMMON_CONTENT_DESCRIPTORS_H_

7	7

8 #include "build/build_config.h"	8 #include "build/build_config.h"

9 #include "ipc/ipc_descriptors.h"	9 #include "ipc/ipc_descriptors.h"

10	10

11 // This is a list of global descriptor keys to be used with the	11 // This is a list of global descriptor keys to be used with the

12 // base::GlobalDescriptors object (see base/posix/global_descriptors.h)	12 // base::GlobalDescriptors object (see base/posix/global_descriptors.h)

13 enum {	13 enum {

14 kCrashDumpSignal = kIPCDescriptorMax,	14 kCrashDumpSignal = kIPCDescriptorMax,

15 kSandboxIPCChannel, // https://chromium.googlesource.com/chromium/src/+/maste r/docs/linux_sandbox_ipc.md	15 kSandboxIPCChannel, // https://chromium.googlesource.com/chromium/src/+/maste r/docs/linux_sandbox_ipc.md

16 kMojoIPCChannel,	16 kMojoIPCChannel,

	17 kFieldTrialHandle,
	Alexei Svitkine (slow) 2016/11/28 16:56:13 This name is very confusing since it's the same na This name is very confusing since it's the same name as the command line flag on Windows. Suggest renaming - how about kFieldTrialDescriptor since this is posix code? lawrencewu 2016/11/29 14:38:07 Done. Show quoted text On 2016/11/28 16:56:13, Alexei Svitkine (slow) wrote: > This name is very confusing since it's the same name as the command line flag on > Windows. > > Suggest renaming - how about kFieldTrialDescriptor since this is posix code? Done.
17	18

18 #if defined(V8_USE_EXTERNAL_STARTUP_DATA)	19 #if defined(V8_USE_EXTERNAL_STARTUP_DATA)

19 kV8NativesDataDescriptor,	20 kV8NativesDataDescriptor,

20 #if defined(OS_ANDROID)	21 #if defined(OS_ANDROID)

21 kV8SnapshotDataDescriptor32,	22 kV8SnapshotDataDescriptor32,

22 kV8SnapshotDataDescriptor64,	23 kV8SnapshotDataDescriptor64,

23 #else	24 #else

24 kV8SnapshotDataDescriptor,	25 kV8SnapshotDataDescriptor,

25 #endif	26 #endif

26 #endif	27 #endif

27	28

28 #if defined(OS_ANDROID)	29 #if defined(OS_ANDROID)

29 kAndroidPropertyDescriptor,	30 kAndroidPropertyDescriptor,

30 kAndroidICUDataDescriptor,	31 kAndroidICUDataDescriptor,

31 #endif	32 #endif

32	33

33 // The first key that embedders can use to register descriptors (see	34 // The first key that embedders can use to register descriptors (see

34 // base/posix/global_descriptors.h).	35 // base/posix/global_descriptors.h).

35 kContentIPCDescriptorMax	36 kContentIPCDescriptorMax

36 };	37 };

37	38

38 #endif // CONTENT_PUBLIC_COMMON_CONTENT_DESCRIPTORS_H_	39 #endif // CONTENT_PUBLIC_COMMON_CONTENT_DESCRIPTORS_H_

OLD	NEW