Share field trial allocator on zygote-using Linuxes

base/metrics/field_trial_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/metrics/field_trial.h"
 
 #include <stddef.h>
 
 #include "base/base_switches.h"
 #include "base/build_time.h"
@@ skipping 1128 matching lines @@
 TEST(FieldTrialListTest, TestCopyFieldTrialStateToFlags) {
   base::FieldTrialList field_trial_list(
       base::MakeUnique<base::MockEntropyProvider>());
   base::FieldTrialList::CreateFieldTrial("Trial1", "Group1");
   base::FilePath test_file_path = base::FilePath(FILE_PATH_LITERAL("Program"));
   base::CommandLine cmd_line = base::CommandLine(test_file_path);
   const char field_trial_handle[] = "test-field-trial-handle";
 
   base::FieldTrialList::CopyFieldTrialStateToFlags(field_trial_handle,
                                                    &cmd_line);
-#if defined(OS_WIN)
   EXPECT_TRUE(cmd_line.HasSwitch(field_trial_handle) ||
               cmd_line.HasSwitch(switches::kForceFieldTrials));
-#else
-  EXPECT_TRUE(cmd_line.HasSwitch(switches::kForceFieldTrials));
-#endif
 }

[Alexei Svitkine (slow), 2016/11/29 17:38:27]

Suggest keeping this test and just make it Windows only.

[lawrencewu, 2016/11/29 19:11:01]

Done.

 
 TEST(FieldTrialListTest, InstantiateAllocator) {
   FieldTrialList field_trial_list(nullptr);
   FieldTrialList::CreateFieldTrial("Trial1", "Group1");
 
   FieldTrialList::InstantiateFieldTrialAllocatorIfNeeded();
   void* memory = field_trial_list.field_trial_allocator_->shared_memory();
   size_t used = field_trial_list.field_trial_allocator_->used();
 
   // Ensure that the function is idempotent.
@@ skipping 58 matching lines @@
   std::unique_ptr<base::SharedMemory> shm(new SharedMemory(handle, true));
   // 4 KiB is enough to hold the trials only created for this test.
   shm.get()->Map(4 << 10);
   FieldTrialList::CreateTrialsFromSharedMemory(std::move(shm));
   std::string check_string;
   FieldTrialList::AllStatesToString(&check_string);
   ASSERT_EQ(check_string.find("Simulated"), std::string::npos);
 }
 
 }  // namespace base