Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 2530533002: [debug-wrapper] adapt stepping tests to inspector behavior. (Closed)

Created:
4 years ago by Yang
Modified:
4 years ago
Reviewers:
jgruber
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debug-wrapper] adapt stepping tests to inspector behavior. R=jgruber@chromium.org BUG=v8:5530 Committed: https://crrev.com/86d38086f8ce2aa9ccb49214a834f5078d12cd13 Cr-Commit-Position: refs/heads/master@{#41215}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -18 lines) Patch
M test/debugger/debug/es6/debug-stepin-microtasks.js View 3 chunks +4 lines, -2 lines 0 comments Download
M test/debugger/debug/regress/regress-crbug-568477-1.js View 1 chunk +3 lines, -2 lines 0 comments Download
M test/debugger/debug/regress/regress-crbug-568477-2.js View 1 chunk +3 lines, -4 lines 0 comments Download
M test/debugger/debug/regress/regress-crbug-568477-3.js View 1 chunk +3 lines, -2 lines 0 comments Download
M test/debugger/debug/regress/regress-crbug-568477-4.js View 1 chunk +4 lines, -4 lines 0 comments Download
M test/debugger/debugger.status View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Yang
4 years ago (2016-11-23 11:54:22 UTC) #1
jgruber
lgtm, thanks!
4 years ago (2016-11-23 12:10:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2530533002/1
4 years ago (2016-11-23 12:13:13 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-23 12:38:09 UTC) #6
commit-bot: I haz the power
4 years ago (2016-11-23 12:38:39 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/86d38086f8ce2aa9ccb49214a834f5078d12cd13
Cr-Commit-Position: refs/heads/master@{#41215}

Powered by Google App Engine
This is Rietveld 408576698