Automated tests for the shift key.

Automated tests for the shift key. Added:
1) Initial shift key sanity checks
2) Highlighting capitalization
3) Chording base cases.
4) Capitalization on long press.
5) Capitalization on double click.
BUG=295049
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226513

[rsadam, 2013-09-30 21:24:36]

Added additional tests as discussed.

[kevers, 2013-09-30 21:58:28]

https://codereview.chromium.org/25305003/diff/3001/chrome/test/data/chromeos/...
File chrome/test/data/chromeos/virtual_keyboard/control_keys_test.js (right):

https://codereview.chromium.org/25305003/diff/3001/chrome/test/data/chromeos/...
chrome/test/data/chromeos/virtual_keyboard/control_keys_test.js:8: * Gets all
shift keys on the keyboard.
This description does not appear to be consistent with the following parameter.
Perhaps something like:

Retrieves the left or right shift keys. Shift keys come in pairs for upper and
lowercase keyboard layouts respectively.

https://codereview.chromium.org/25305003/diff/3001/chrome/test/data/chromeos/...
chrome/test/data/chromeos/virtual_keyboard/control_keys_test.js:9: * @param
{string} alignment, Which of {left, right} shift keys to return.
Nit. No punctuation between variable name and description.

https://codereview.chromium.org/25305003/diff/3001/chrome/test/data/chromeos/...
chrome/test/data/chromeos/virtual_keyboard/control_keys_test.js:10: * @return
{{string: string}} a map from keyset to the shift key in it.
{Object.<string, Object>} ?

https://codereview.chromium.org/25305003/diff/3001/chrome/test/data/chromeos/...
chrome/test/data/chromeos/virtual_keyboard/control_keys_test.js:40:
assertTrue(keyboard.keyset == lower, "Start keyset should by: " +
should by -> should be

Use assertEquals here rather than assertTrue. The expected and actual response
are both printed as part of a test failure, thus it is not necessary to repeat
in the message.  The message can simply indicate the stage of the test.

https://codereview.chromium.org/25305003/diff/3001/chrome/test/data/chromeos/...
chrome/test/data/chromeos/virtual_keyboard/control_keys_test.js:71: "Initial
keyboard keyset is not unlocked. Keyset: " +
assertEquals

https://codereview.chromium.org/25305003/diff/3001/chrome/test/data/chromeos/...
chrome/test/data/chromeos/virtual_keyboard/control_keys_test.js:102:
assertTrue(shift.lowerCaseKeysetId == expectedUnlocked,
assertEquals

https://codereview.chromium.org/25305003/diff/3001/chrome/test/data/chromeos/...
chrome/test/data/chromeos/virtual_keyboard/control_keys_test.js:121:
assertTrue(keyboard.keyset == unlocked,
assertEquals

https://codereview.chromium.org/25305003/diff/3001/chrome/test/data/chromeos/...
chrome/test/data/chromeos/virtual_keyboard/control_keys_test.js:151:
assertTrue(keyboard.keyset == unlocked,
assertEquals

[rsadam, 2013-09-30 22:52:08]

Fixed changes you suggested!

https://codereview.chromium.org/25305003/diff/3001/chrome/test/data/chromeos/...
File chrome/test/data/chromeos/virtual_keyboard/control_keys_test.js (right):

https://codereview.chromium.org/25305003/diff/3001/chrome/test/data/chromeos/...
chrome/test/data/chromeos/virtual_keyboard/control_keys_test.js:8: * Gets all
shift keys on the keyboard.
On 2013/09/30 21:58:28, kevers wrote:
> This description does not appear to be consistent with the following
parameter.
> Perhaps something like:
> 
> Retrieves the left or right shift keys. Shift keys come in pairs for upper and
> lowercase keyboard layouts respectively.

Done.

https://codereview.chromium.org/25305003/diff/3001/chrome/test/data/chromeos/...
chrome/test/data/chromeos/virtual_keyboard/control_keys_test.js:9: * @param
{string} alignment, Which of {left, right} shift keys to return.
On 2013/09/30 21:58:28, kevers wrote:
> Nit. No punctuation between variable name and description.

Done.

https://codereview.chromium.org/25305003/diff/3001/chrome/test/data/chromeos/...
chrome/test/data/chromeos/virtual_keyboard/control_keys_test.js:10: * @return
{{string: string}} a map from keyset to the shift key in it.
On 2013/09/30 21:58:28, kevers wrote:
> {Object.<string, Object>} ?

Done.

https://codereview.chromium.org/25305003/diff/3001/chrome/test/data/chromeos/...
chrome/test/data/chromeos/virtual_keyboard/control_keys_test.js:40:
assertTrue(keyboard.keyset == lower, "Start keyset should by: " +
On 2013/09/30 21:58:28, kevers wrote:
> should by -> should be
> 
> Use assertEquals here rather than assertTrue. The expected and actual response
> are both printed as part of a test failure, thus it is not necessary to repeat
> in the message.  The message can simply indicate the stage of the test.

Done.

https://codereview.chromium.org/25305003/diff/3001/chrome/test/data/chromeos/...
chrome/test/data/chromeos/virtual_keyboard/control_keys_test.js:71: "Initial
keyboard keyset is not unlocked. Keyset: " +
On 2013/09/30 21:58:28, kevers wrote:
> assertEquals

Done.

https://codereview.chromium.org/25305003/diff/3001/chrome/test/data/chromeos/...
chrome/test/data/chromeos/virtual_keyboard/control_keys_test.js:102:
assertTrue(shift.lowerCaseKeysetId == expectedUnlocked,
On 2013/09/30 21:58:28, kevers wrote:
> assertEquals

Done.

https://codereview.chromium.org/25305003/diff/3001/chrome/test/data/chromeos/...
chrome/test/data/chromeos/virtual_keyboard/control_keys_test.js:121:
assertTrue(keyboard.keyset == unlocked,
On 2013/09/30 21:58:28, kevers wrote:
> assertEquals

Done.

https://codereview.chromium.org/25305003/diff/3001/chrome/test/data/chromeos/...
chrome/test/data/chromeos/virtual_keyboard/control_keys_test.js:151:
assertTrue(keyboard.keyset == unlocked,
On 2013/09/30 21:58:28, kevers wrote:
> assertEquals

Done.

[kevers, 2013-10-01 19:27:49]

lgtm with nits.

https://codereview.chromium.org/25305003/diff/8001/chrome/test/data/chromeos/...
File chrome/test/data/chromeos/virtual_keyboard/control_keys_test.js (right):

https://codereview.chromium.org/25305003/diff/8001/chrome/test/data/chromeos/...
chrome/test/data/chromeos/virtual_keyboard/control_keys_test.js:132: 
Add jsdoc.

https://codereview.chromium.org/25305003/diff/8001/chrome/test/data/chromeos/...
chrome/test/data/chromeos/virtual_keyboard/control_keys_test.js:141: var
mockEvent = { pointerId: 1};
nit: remove space after {

https://codereview.chromium.org/25305003/diff/8001/chrome/test/data/chromeos/...
chrome/test/data/chromeos/virtual_keyboard/control_keys_test.js:163: * @param
{function} testDoneCallBack The callback function to be called
Description seems a bit redundant.  Can reduce "The callback function to be
called" to "The function to be called" here and below.

[rsadam, 2013-10-01 21:29:17]

Fixed nits, +mpcomplete for OWNERS

https://codereview.chromium.org/25305003/diff/8001/chrome/test/data/chromeos/...
File chrome/test/data/chromeos/virtual_keyboard/control_keys_test.js (right):

https://codereview.chromium.org/25305003/diff/8001/chrome/test/data/chromeos/...
chrome/test/data/chromeos/virtual_keyboard/control_keys_test.js:132: 
On 2013/10/01 19:27:49, kevers wrote:
> Add jsdoc.

Done.

https://codereview.chromium.org/25305003/diff/8001/chrome/test/data/chromeos/...
chrome/test/data/chromeos/virtual_keyboard/control_keys_test.js:141: var
mockEvent = { pointerId: 1};
On 2013/10/01 19:27:49, kevers wrote:
> nit: remove space after {

Done.

https://codereview.chromium.org/25305003/diff/8001/chrome/test/data/chromeos/...
chrome/test/data/chromeos/virtual_keyboard/control_keys_test.js:163: * @param
{function} testDoneCallBack The callback function to be called
On 2013/10/01 19:27:49, kevers wrote:
> Description seems a bit redundant.  Can reduce "The callback function to be
> called" to "The function to be called" here and below.

Done.

[Matt Perry, 2013-10-01 21:50:00]

lgtm

[commit-bot: I haz the power, 2013-10-02 13:06:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsadam@chromium.org/25305003/13001

[commit-bot: I haz the power, 2013-10-02 14:42:39]

Retried try job too often on win7_aura for step(s) unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...

[commit-bot: I haz the power, 2013-10-02 16:01:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsadam@chromium.org/25305003/13001

[commit-bot: I haz the power, 2013-10-02 18:35:07]

Change committed as 226513