chrome/test/data/extensions/api_test/browser_action/open_popup/open_popup_succeeds.js - Issue 25305002: Implement initial chrome.browserAction.openPopup API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/api_test/browser_action/open_popup/open_popup_succeeds.js

Issue 25305002: Implement initial chrome.browserAction.openPopup API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixes Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/extension_action/extension_action_api.cc ('K') | « chrome/test/data/extensions/api_test/browser_action/open_popup/open_popup_succeeds.html ('k') | chrome/test/data/extensions/api_test/browser_action/open_popup/popup.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/api_test/browser_action/open_popup/open_popup_succeeds.js

diff --git a/chrome/test/data/extensions/api_test/browser_action/open_popup/open_popup_succeeds.js b/chrome/test/data/extensions/api_test/browser_action/open_popup/open_popup_succeeds.js

new file mode 100644

index 0000000000000000000000000000000000000000..68d1206b07e63d4479a2dd8e6e8e81fc1a120982

--- /dev/null

+++ b/chrome/test/data/extensions/api_test/browser_action/open_popup/open_popup_succeeds.js

@@ -0,0 +1,16 @@

+// Use of this source code is governed by a BSD-style license that can be

+// found in the LICENSE file.

+// Open a popup then return control to the ApiTest.

+// The ApiTest can reply to the ready message to request another popup to open.

+chrome.browserAction.openPopup(function(popupWindow) {

+ chrome.test.assertTrue(!!popupWindow);

+ chrome.test.notifyPass();

+ chrome.test.sendMessage('ready', function() {

+ chrome.browserAction.openPopup(function(popupWindow2) {

+ chrome.test.assertTrue(!!popupWindow2);

+ chrome.test.succeed();

+ });

+});