chrome/test/data/extensions/api_test/browser_action/open_popup/manifest.json - Issue 25305002: Implement initial chrome.browserAction.openPopup API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/api_test/browser_action/open_popup/manifest.json

Issue 25305002: Implement initial chrome.browserAction.openPopup API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/browser_actions_container.cc ('K') | « chrome/renderer/resources/extensions/browser_action_custom_bindings.js ('k') | chrome/test/data/extensions/api_test/browser_action/open_popup/open_popup_succeeds.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/api_test/browser_action/open_popup/manifest.json

diff --git a/chrome/test/data/extensions/api_test/browser_action/open_popup/manifest.json b/chrome/test/data/extensions/api_test/browser_action/open_popup/manifest.json

new file mode 100644

index 0000000000000000000000000000000000000000..892a620e0a52d907b284ee5d4338ef8cbb97496f

--- /dev/null

+++ b/chrome/test/data/extensions/api_test/browser_action/open_popup/manifest.json

@@ -0,0 +1,10 @@

+ "name": "OpenPopup Test",

+ "version": "1",

+ "manifest_version": 2,

+ "description": "Apitest for chrome.browserAction.openPopup",

+ "incognito": "split",

+ "browser_action": {

+ "default_popup": "popup.html"

+ }