chrome/browser/ui/views/browser_actions_container.h - Issue 25305002: Implement initial chrome.browserAction.openPopup API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/browser_actions_container.h

Issue 25305002: Implement initial chrome.browserAction.openPopup API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/extension_toolbar_model.h ('K') | « chrome/browser/ui/gtk/browser_actions_toolbar_gtk.cc ('k') | chrome/browser/ui/views/browser_actions_container.cc » ('j') | chrome/browser/ui/views/browser_actions_container.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/browser_actions_container.h

diff --git a/chrome/browser/ui/views/browser_actions_container.h b/chrome/browser/ui/views/browser_actions_container.h

index 9e3fc949c58b67c126b73e3f558ee3d9f8a75b6f..5970d2828f32551800f886311698657affa8b14f 100644

--- a/chrome/browser/ui/views/browser_actions_container.h

+++ b/chrome/browser/ui/views/browser_actions_container.h

@@ -259,6 +259,8 @@ class BrowserActionsContainer

const extensions::Extension* extension) OVERRIDE;

virtual void BrowserActionMoved(const extensions::Extension* extension,

int index) OVERRIDE;

+ virtual void BrowserActionShowPopup(

+ const extensions::Extension* extension) OVERRIDE;

virtual void ModelLoaded() OVERRIDE;

void LoadImages();

@@ -311,6 +313,9 @@ class BrowserActionsContainer

// Show a popup.

void ShowPopup(BrowserActionButton* button,

+ ExtensionPopup::ShowAction show_action,

+ bool should_grant);

+ void ShowPopup(BrowserActionButton* button,

ExtensionPopup::ShowAction show_action);

// The vector of browser actions (icons/image buttons for each action). Note