Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Unified Diff: chrome/common/extensions/features/complex_feature.cc

Issue 25305002: Implement initial chrome.browserAction.openPopup API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: move to interactive_ui_test Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/features/complex_feature.cc
diff --git a/chrome/common/extensions/features/complex_feature.cc b/chrome/common/extensions/features/complex_feature.cc
index 5b11019fcf63d27f0b7654d7da3342481c423824..a1cedfaacba76e4e0f5747180ee15629a13949a2 100644
--- a/chrome/common/extensions/features/complex_feature.cc
+++ b/chrome/common/extensions/features/complex_feature.cc
@@ -66,8 +66,8 @@ std::set<Feature::Context>* ComplexFeature::GetContexts() {
}
bool ComplexFeature::IsInternal() const {
- NOTREACHED();
- return false;
+ // TODO(justinlin): Same as the above TODO.
+ return features_[0]->IsInternal();
}
std::string ComplexFeature::GetAvailabilityMessage(AvailabilityResult result,

Powered by Google App Engine
This is Rietveld 408576698