chrome/browser/ui/gtk/browser_actions_toolbar_gtk.h - Issue 25305002: Implement initial chrome.browserAction.openPopup API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/gtk/browser_actions_toolbar_gtk.h

Issue 25305002: Implement initial chrome.browserAction.openPopup API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: move to interactive_ui_test Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm ('k') | chrome/browser/ui/gtk/browser_actions_toolbar_gtk.cc » ('j') | chrome/renderer/resources/extensions/browser_action_custom_bindings.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/gtk/browser_actions_toolbar_gtk.h

diff --git a/chrome/browser/ui/gtk/browser_actions_toolbar_gtk.h b/chrome/browser/ui/gtk/browser_actions_toolbar_gtk.h

index 8cb03c79e5ec94f5bcd44e9412a58aaa57635272..cb4209b930ae96958904fbf9f49c930ee2b67e50 100644

--- a/chrome/browser/ui/gtk/browser_actions_toolbar_gtk.h

+++ b/chrome/browser/ui/gtk/browser_actions_toolbar_gtk.h

@@ -52,6 +52,8 @@ class BrowserActionsToolbarGtk : public ExtensionToolbarModel::Observer,

// |extension|. Used in positioning the ExtensionInstalledBubble for

// BrowserActions.

GtkWidget* GetBrowserActionWidget(const extensions::Extension* extension);

+ BrowserActionButton* GetBrowserActionButton(

+ const extensions::Extension* extension);

int button_count() { return extension_button_map_.size(); }

@@ -118,6 +120,8 @@ class BrowserActionsToolbarGtk : public ExtensionToolbarModel::Observer,

const extensions::Extension* extension) OVERRIDE;

virtual void BrowserActionMoved(const extensions::Extension* extension,

int index) OVERRIDE;

+ virtual bool BrowserActionShowPopup(

+ const extensions::Extension* extension) OVERRIDE;

virtual void ModelLoaded() OVERRIDE;

// gfx::AnimationDelegate implementation.