Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Unified Diff: chrome/browser/extensions/api/extension_action/page_as_browser_action_apitest.cc

Issue 25305002: Implement initial chrome.browserAction.openPopup API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: move to interactive_ui_test Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/extension_action/page_as_browser_action_apitest.cc
diff --git a/chrome/browser/extensions/api/extension_action/page_as_browser_action_apitest.cc b/chrome/browser/extensions/api/extension_action/page_as_browser_action_apitest.cc
index 196ecc1d7c72b46262b14f94104825ddea8d18d0..34eb519d7eb7f070f08207312bf390e36189528a 100644
--- a/chrome/browser/extensions/api/extension_action/page_as_browser_action_apitest.cc
+++ b/chrome/browser/extensions/api/extension_action/page_as_browser_action_apitest.cc
@@ -91,7 +91,8 @@ IN_PROC_BROWSER_TEST_F(PageAsBrowserActionApiTest, Basic) {
ResultCatcher catcher;
ExtensionService* service = extensions::ExtensionSystem::Get(
browser()->profile())->extension_service();
- service->toolbar_model()->ExecuteBrowserAction(extension, browser(), NULL);
+ service->toolbar_model()->ExecuteBrowserAction(
+ extension, browser(), NULL, true);
EXPECT_TRUE(catcher.GetNextResult());
}
@@ -135,7 +136,8 @@ IN_PROC_BROWSER_TEST_F(PageAsBrowserActionApiTest, AddPopup) {
ResultCatcher catcher;
ExtensionService* service = extensions::ExtensionSystem::Get(
browser()->profile())->extension_service();
- service->toolbar_model()->ExecuteBrowserAction(extension, browser(), NULL);
+ service->toolbar_model()->ExecuteBrowserAction(
+ extension, browser(), NULL, true);
ASSERT_TRUE(catcher.GetNextResult());
}
@@ -202,5 +204,5 @@ IN_PROC_BROWSER_TEST_F(PageAsBrowserActionApiTest, Getters) {
ASSERT_TRUE(catcher.GetNextResult());
}
-}
+} // namespace
} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698