chrome/browser/extensions/error_console/error_console_browsertest.cc - Issue 25305002: Implement initial chrome.browserAction.openPopup API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/error_console/error_console_browsertest.cc

Issue 25305002: Implement initial chrome.browserAction.openPopup API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add comment Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/extension_action/page_as_browser_action_apitest.cc ('k') | chrome/browser/extensions/extension_function_histogram_value.h » ('j') | chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/error_console/error_console_browsertest.cc

diff --git a/chrome/browser/extensions/error_console/error_console_browsertest.cc b/chrome/browser/extensions/error_console/error_console_browsertest.cc

index 3e2ab2fc3c8f605775150a13ca3b86bb9f6feda5..952ff52263997b527d8eca51b04451efd2d836be 100644

--- a/chrome/browser/extensions/error_console/error_console_browsertest.cc

+++ b/chrome/browser/extensions/error_console/error_console_browsertest.cc

@@ -247,7 +247,7 @@ class ErrorConsoleBrowserTest : public ExtensionBrowserTest {

ExtensionService* service =

extensions::ExtensionSystem::Get(profile())->extension_service();

service->toolbar_model()->ExecuteBrowserAction(

- *extension, browser(), NULL);

+ *extension, browser(), NULL, true);

break;

}

case ACTION_NONE: