Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4644)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/common/extensions/features/complex_feature.cc

Issue 25305002: Implement initial chrome.browserAction.openPopup API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: finnur@ comments Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/ui/views/browser_actions_container.cc ('K') | « chrome/common/extensions/api/browser_action.json ('k') | chrome/renderer/resources/extensions/browser_action_custom_bindings.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/features/complex_feature.cc
diff --git a/chrome/common/extensions/features/complex_feature.cc b/chrome/common/extensions/features/complex_feature.cc
index 57c9ad4d943bf730a22874276e5f9fd9e3580cc1..3668a5b1bade21c5e140db3cfc4204d50d27110b 100644
--- a/chrome/common/extensions/features/complex_feature.cc
+++ b/chrome/common/extensions/features/complex_feature.cc
@@ -66,8 +66,8 @@ std::set<Feature::Context>* ComplexFeature::GetContexts() {
}
bool ComplexFeature::IsInternal() const {
- NOTREACHED();
- return false;
+ // TODO(justinlin): Same as the above TODO.
+ return features_[0]->IsInternal();
}
std::string ComplexFeature::GetAvailabilityMessage(AvailabilityResult result,
« chrome/browser/ui/views/browser_actions_container.cc ('K') | « chrome/common/extensions/api/browser_action.json ('k') | chrome/renderer/resources/extensions/browser_action_custom_bindings.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698