chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm - Issue 25305002: Implement initial chrome.browserAction.openPopup API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm

Issue 25305002: Implement initial chrome.browserAction.openPopup API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/extension_action/extension_action_api.cc ('K') | « chrome/browser/extensions/extension_function_histogram_value.h ('k') | chrome/browser/ui/views/browser_actions_container.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm

diff --git a/chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm b/chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm

index a17f3d8cde36d18dbab3e47d97209012f9400896..0d1dd6d566ee4c3d9e2950d71b94de31e42bbe96 100644

--- a/chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm

+++ b/chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm

@@ -204,9 +204,10 @@ class ExtensionServiceObserverBridge : public content::NotificationObserver,

content::Details<std::pair<const std::string, gfx::NativeWindow> >(

details).ptr();

std::string extension_id = payload->first;

- gfx::NativeWindow window = payload->second;

- if (window != browser_->window()->GetNativeWindow())

- break;

+ // gfx::NativeWindow window = payload->second;

+ // if (window != browser_->window()->GetNativeWindow())

+ // break;

+ // gfx::NativeWindow window = browser_->window()->GetNativeWindow();

ExtensionService* service = browser_->profile()->GetExtensionService();

if (!service)

break;