chrome/test/data/extensions/api_test/browser_action/open_popup/manifest.json - Issue 25305002: Implement initial chrome.browserAction.openPopup API.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/extensions/api_test/browser_action/open_popup/manifest.json

Issue 25305002: Implement initial chrome.browserAction.openPopup API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/renderer/resources/extensions/browser_action_custom_bindings.js ('K') | « chrome/test/data/extensions/api_test/browser_action/open_popup/chromium.png ('k') | chrome/test/data/extensions/api_test/browser_action/open_popup/open_popup_succeeds.html » ('j') | chrome/test/data/extensions/api_test/browser_action/open_popup/open_popup_succeeds.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 {

	2 "name": "OpenPopup Test",

	3 "version": "1",

	4 "manifest_version": 2,

	5 "description": "Apitest for chrome.browserAction.openPopup",

	6 "incognito": "split",

	7 "browser_action": {

	8 "default_icon": "chromium.png",
	Finnur 2013/10/15 10:44:21 If you can get away with not using an icon, then I If you can get away with not using an icon, then I would. Fewer files, less space used and you can use the try servers for the whole change (don't need to check in the image first). justinlin 2013/10/16 07:06:48 Done. Good point, the other ones should probably b Show quoted text On 2013/10/15 10:44:21, Finnur wrote: > If you can get away with not using an icon, then I would. Fewer files, less > space used and you can use the try servers for the whole change (don't need to > check in the image first). Done. Good point, the other ones should probably be removed too. I think the icon used to be required, but looks like not anymore.
	9 "default_popup": "popup.html"

	10 }

	11 }

OLD	NEW