Implement initial chrome.browserAction.openPopup API.

chrome/common/extensions/api/_api_features.json

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // See c/c/e/features/* to understand this file, in particular feature.h,
 // simple_feature.h, and base_feature_provider.h.
 
 {
   "activityLogPrivate": {
     "dependencies": ["permission:activityLogPrivate"],
@@ skipping 84 matching lines @@
   "bookmarks.import": {
     "extension_types": ["extension"],
     "location": "component"
   },
   "brailleDisplayPrivate": {
     "dependencies": ["permission:brailleDisplayPrivate"],
     "contexts": ["blessed_extension"]
   },
   "browserAction": {
     "dependencies": ["manifest:browser_action"],
+    "contexts": ["blessed_extension", "unblessed_extension"]

[Finnur, 2013/10/15 10:44:21]

I must admit I don't know what unblessed_extension means as I've never used it.
Why is it necessary to add this here?

[justinlin, 2013/10/16 07:06:48]

I don't quite know either. I think I added this with the intention of finding
out, but I haven't quite figured out yet and I don't think we need it. We can
add it if needed.

[Finnur, 2013/10/16 15:01:26]

Um... can you remove it then? :)

[justinlin, 2013/10/16 19:31:29]

Thought I did. Oh, I accidentally added it to the above. Oops, removed.

+  },
+  "browserAction.showPopup": [{

[Finnur, 2013/10/15 10:44:21]

Please comment that you are restricting this to the dev channel and whitelisting
it on stable. Also that security concerns need to be addressed before making it
available to a wider audience (e.g. by removing the whitelist). I'm actually
wondering if just whitelisting for a few extensions is enough for all channels,
as I don't see the point of keeping this live on dev if we don't intend to
release it for everyone to stable.

What is the plan?

[justinlin, 2013/10/16 07:06:48]

Done. I believe the plan is to first whitelist this API for a set of extensions,
but enable on dev as well while working through the issues. We can move it to
stable once it seems ready.

[Finnur, 2013/10/16 15:01:26]

I'd like to make this comment more explicit, for example:

This API is whitelisted on stable and should not be enabled for a wider audience
without resolving security issues raised in API proposal and review
(https://codereview.chromium.org/25305002).

[justinlin, 2013/10/16 19:31:29]

Done. OK, that wording seems better.

+    "channel": "dev",
+    "dependencies": ["manifest:browser_action"],
     "contexts": ["blessed_extension"]
-  },
+  }, {
+    "channel": "stable",
+    "dependencies": ["manifest:browser_action"],
+    "whitelist": [
+      "enhhojjnijigcajfphajepfemndkmdlo",  // Dev
+      "pkedcjkdefgpdelpbcmbmeomcjbeemfm",  // Trusted Tester
+      "fmfcbgogabcbclcofgocippekhfcmgfj",  // Staging
+      "hfaagokkkhdbgiakmmlclaapfelnkoah",  // Canary
+      "F155646B5D1CA545F7E1E4E20D573DFDD44C2540",  // Trusted Tester (public)
+      "16CA7A47AAE4BE49B1E75A6B960C3875E945B264"   // Release
+    ],
+    "contexts": ["blessed_extension"]
+  }],
   "browsingData": {
     "dependencies": ["permission:browsingData"],
     "contexts": ["blessed_extension"]
   },
   "cast.channel": {
     "dependencies": ["permission:cast"],
     "contexts": ["blessed_extension"]
   },
   "chromeosInfoPrivate": {
     "platform": "chromeos",
@@ skipping 550 matching lines @@
     "internal": true,
     "channel": "stable",
     "dependencies": ["permission:webview"],
     "contexts": ["blessed_extension"]
   },
   "windows": {
     "dependencies": ["api:tabs"],
     "contexts": ["blessed_extension"]
   }
 }