Implement initial chrome.browserAction.openPopup API.

chrome/browser/extensions/extension_toolbar_model.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_TOOLBAR_MODEL_H_
 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_TOOLBAR_MODEL_H_
 
 #include "base/compiler_specific.h"
 #include "base/observer_list.h"
 #include "base/prefs/pref_change_registrar.h"
@@ skipping 30 matching lines @@
     virtual void BrowserActionAdded(const extensions::Extension* extension,
                                     int index) {}
 
     // The browser action button for |extension| should no longer show.
     virtual void BrowserActionRemoved(const extensions::Extension* extension) {}
 
     // The browser action button for |extension| has been moved to |index|.
     virtual void BrowserActionMoved(const extensions::Extension* extension,
                                     int index) {}
 
+    // The browser action should show the popup now.

[Finnur, 2013/10/15 10:44:21]

nit: The browser action for |extension| should...

[justinlin, 2013/10/16 07:06:48]

Done.

+    virtual void BrowserActionShowPopup(
+        const extensions::Extension* extension) {}
+
     // Called when the model has finished loading.
     virtual void ModelLoaded() {}
 
    protected:
     virtual ~Observer() {}
   };
 
   // Functions called by the view.
   void AddObserver(Observer* observer);
   void RemoveObserver(Observer* observer);
   void MoveBrowserAction(const extensions::Extension* extension, int index);
+  void ShowBrowserActionPopup(const extensions::Extension* extension);
   // Executes the browser action for an extension and returns the action that
   // the UI should perform in response.
   // |popup_url_out| will be set if the extension should show a popup, with
   // the URL that should be shown, if non-NULL.
   Action ExecuteBrowserAction(const extensions::Extension* extension,
                               Browser* browser,
                               GURL* popup_url_out);
+  // Retrieves the URL that should be loaded in the popup for an extension
+  // without granting host permissions for the tab. Used for the showPopup API.
+  GURL GetPopupUrl(const extensions::Extension* extension, Browser* browser);
   // If count == size(), this will set the visible icon count to -1, meaning
   // "show all actions".
   void SetVisibleIconCount(int count);
   // As above, a return value of -1 represents "show all actions".
   int GetVisibleIconCount() const { return visible_icon_count_; }
 
   bool extensions_initialized() const { return extensions_initialized_; }
 
   const extensions::ExtensionList& toolbar_items() const {
     return toolbar_items_;
@@ skipping 58 matching lines @@
   // For observing change of toolbar order preference by external entity (sync).
   PrefChangeRegistrar pref_change_registrar_;
   base::Closure pref_change_callback_;
 
   base::WeakPtrFactory<ExtensionToolbarModel> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(ExtensionToolbarModel);
 };
 
 #endif  // CHROME_BROWSER_EXTENSIONS_EXTENSION_TOOLBAR_MODEL_H_